chore: remove support for versions < 3.23

Author: pd93

src/providers/taskTreeDataProvider.ts

@@ -42,13 +42,6 @@ export class TaskTreeDataProvider implements vscode.TreeDataProvider<elements.Tr
             return Promise.resolve([]);
         }
 
-        // Check if the workspace folder is the same as the taskfile location.
-        // If there is no location available (Task v3.22 or older), compare against the workspace instead.
-        // This has the downside the tasks from Taskfiles outside of the workspace folder might be shown.
-        if (vscode.workspace.workspaceFolders[0].uri.fsPath !== (this._taskfiles[0].location ? path.dirname(this._taskfiles[0].location) : this._taskfiles[0].workspace)) {
-            return Promise.resolve([]);
-        }
-
         var tasks: models.Task[] | undefined;
         var parentNamespace = "";
         var workspace = "";
@@ -128,20 +121,14 @@ export class TaskTreeDataProvider implements vscode.TreeDataProvider<elements.Tr
     getWorkspaces(): elements.WorkspaceTreeItem[] {
         let workspaceTreeItems: elements.WorkspaceTreeItem[] = [];
         this._taskfiles?.forEach(taskfile => {
-            vscode.workspace.workspaceFolders?.forEach(workspace => {
-                // Check if the workspace folder is the same as the taskfile location.
-                // If there is no location available (Task v3.22 or older), compare against the workspace instead.
-                // This has the downside the tasks from Taskfiles outside of the workspace folder might be shown.
-                if (workspace.uri.fsPath === (taskfile.location ? path.dirname(taskfile.location) : taskfile.workspace)) {
-                    let workspaceTreeItem = new elements.WorkspaceTreeItem(
-                        workspace.name,
-                        workspace.uri.fsPath,
-                        taskfile.tasks,
-                        vscode.TreeItemCollapsibleState.Expanded
-                    );
-                    workspaceTreeItems = workspaceTreeItems.concat(workspaceTreeItem);
-                }
-            });
+            let dir = path.dirname(taskfile.location);
+            let workspaceTreeItem = new elements.WorkspaceTreeItem(
+                path.basename(dir),
+                dir,
+                taskfile.tasks,
+                vscode.TreeItemCollapsibleState.Expanded
+            );
+            workspaceTreeItems = workspaceTreeItems.concat(workspaceTreeItem);
         });
         return workspaceTreeItems;
     }

src/services/taskfile.ts

@@ -12,8 +12,7 @@ const octokit = new Octokit();
 type ReleaseRequest = Endpoints["GET /repos/{owner}/{repo}/releases/latest"]["parameters"];
 type ReleaseResponse = Endpoints["GET /repos/{owner}/{repo}/releases/latest"]["response"];
 
-const minimumRequiredVersion = '3.19.1';
-const minimumRecommendedVersion = '3.23.0';
+const minimumRequiredVersion = '3.23.0';
 
 class TaskfileService {
     private static _instance: TaskfileService;
@@ -61,12 +60,6 @@ class TaskfileService {
                     return resolve("outOfDate");
                 }
 
-                // If the current version is older than the minimum recommended version, show a warning
-                if (version && version.compare(minimumRecommendedVersion) < 0) {
-                    vscode.window.showWarningMessage(`Task v${minimumRecommendedVersion} is recommended to run this extension. Your current version is v${version} which doesn't support some features.`, "Update").then(this.buttonCallback);
-                    return resolve("ready");
-                }
-
                 // If a newer version is available, show a message
                 // TODO: what happens if the user is offline?
                 if (settings.checkForUpdates) {
@@ -143,10 +136,13 @@ class TaskfileService {
     }
 
     public async read(dir: string): Promise<models.Taskfile> {
-        return await new Promise((resolve) => {
+        return await new Promise((resolve, reject) => {
             let command = this.command('--list-all --json');
             cp.exec(command, { cwd: dir }, (_, stdout: string) => {
                 var taskfile: models.Taskfile = JSON.parse(stdout);
+                if (path.dirname(taskfile.location) !== dir) {
+                    return reject();
+                }
                 taskfile.workspace = dir;
                 return resolve(taskfile);
             });
@@ -193,11 +189,6 @@ class TaskfileService {
     }
 
     public async goToDefinition(task: models.Task, preview: boolean = false): Promise<void> {
-        if (task.location === undefined) {
-            vscode.window.showErrorMessage(`Go to definition requires Task v3.23.0 or higher.`, "Update").then(this.buttonCallback);
-            return;
-        }
-
         let position = new vscode.Position(task.location.line - 1, task.location.column - 1);
         let range = new vscode.Range(position, position);
 

src/task.ts

@@ -17,19 +17,29 @@ export class TaskExtension {
 
     public async update(): Promise<void> {
         // Do version checks
-        await services.taskfile.checkInstallation().then((status): Promise<models.Taskfile[]> => {
+        await services.taskfile.checkInstallation().then((status): Promise<PromiseSettledResult<models.Taskfile>[]> => {
+
+            // Set the status
             vscode.commands.executeCommand('setContext', 'vscode-task:status', status);
-            if (status === "ready") {
-                // Read taskfiles
-                let p: Promise<models.Taskfile>[] = [];
-                vscode.workspace.workspaceFolders?.forEach((folder) => {
-                    p.push(services.taskfile.read(folder.uri.fsPath));
-                });
-                return Promise.all(p);
+
+            // If the status is not "ready", reject the promise
+            if (status !== "ready") {
+                return Promise.reject();
+            }
+
+            // Read taskfiles
+            let p: Promise<models.Taskfile>[] = [];
+            vscode.workspace.workspaceFolders?.forEach((folder) => {
+                p.push(services.taskfile.read(folder.uri.fsPath));
+            });
+            return Promise.allSettled(p);
+
+        // If there are no valid taskfiles, set the status to "noTaskfile"
+        }).then(results => {
+            this._taskfiles = results.filter(result => result.status === "fulfilled").map(result => <PromiseFulfilledResult<any>>result).map(result => result.value);
+            if (this._taskfiles.length === 0) {
+                vscode.commands.executeCommand('setContext', 'vscode-task:status', "noTaskfile");
             }
-            return Promise.resolve([]);
-        }).then((taskfiles: models.Taskfile[]) => {
-            this._taskfiles = taskfiles;
         });
     }