Skip to content

Commit cefad4b

Browse files
committed
feat: bump minimum required task version to v3.24.0
1 parent 2036d63 commit cefad4b

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

src/services/taskfile.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ const octokit = new Octokit();
1313
type ReleaseRequest = Endpoints["GET /repos/{owner}/{repo}/releases/latest"]["parameters"];
1414
type ReleaseResponse = Endpoints["GET /repos/{owner}/{repo}/releases/latest"]["response"];
1515

16-
const minimumRequiredVersion = '3.23.0';
17-
const minimumRequiredVersionForSorting = '3.24.0';
18-
const minimumRequiredVersionForExitCodes = '3.24.0';
16+
const minimumRequiredVersion = '3.24.0';
1917

2018
// General exit codes
2119
const errCodeOK = 0;
@@ -177,19 +175,14 @@ class TaskfileService {
177175
let additionalFlags = "";
178176
// Sorting
179177
if (settings.treeSort !== "default") {
180-
if (this.version && this.version.compare(minimumRequiredVersionForSorting) < 0) {
181-
vscode.window.showWarningMessage(`Task version v${minimumRequiredVersionForSorting} is required to change the sort order. Falling back to "default".`, "Update").then(this.buttonCallback);
182-
} else {
183-
additionalFlags = ` --sort ${settings.treeSort}`;
184-
}
178+
additionalFlags = ` --sort ${settings.treeSort}`;
185179
}
186180
let command = this.command(`--list-all --json${additionalFlags}`);
187181
cp.exec(command, { cwd: dir }, (err: cp.ExecException | null, stdout: string, stderr: string) => {
188182
if (err) {
189183
log.error(err);
190-
// TODO: Bump the minimum required version to remove this conditional
191184
let shouldDisplayError = false;
192-
if (err.code && this.version && this.version.compare(minimumRequiredVersionForExitCodes) >= 0) {
185+
if (err.code) {
193186
let exitCodesToDisplayErrorsFor = [
194187
errCodeTaskfileInvalid,
195188
];

0 commit comments

Comments
 (0)