Skip to content

Commit 374a40d

Browse files
Merge branch 'element/ak-spinner' into element/ak-empty-state
* element/ak-spinner: Last-minute changes lead to last-minute bugs.
2 parents e93ee1d + 9e6a81c commit 374a40d

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/ak-spinner/ak-spinner.builder.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import "./ak-spinner.js";
22

3-
import { type Spinner } from "./ak-spinner.js";
3+
import { type Spinner, type SpinnerSize } from "./ak-spinner.component.js";
44

55
import { html } from "lit";
66
import { ifDefined } from "lit/directives/if-defined.js";
77

8-
export type SpinnerProps = Partial<Pick<Spinner, "label">> & { inline?: boolean; size?: string };
8+
export type SpinnerProps = Partial<Pick<Spinner, "label">> & {
9+
inline?: boolean;
10+
size?: SpinnerSize;
11+
};
912

1013
/**
1114
* @summary Helper function to create a Spinner component programmatically

src/ak-spinner/ak-spinner.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ import { html, LitElement } from "lit";
66
import { property } from "lit/decorators.js";
77
import { ifDefined } from "lit/directives/if-defined.js";
88

9+
/**
10+
* Spinner size variants. Prefer T-shirt sizes when possible. Because these have no behavioral
11+
* consquences, they're not actually used here, but we document them here for the `.builder`.
12+
*/
13+
export type SpinnerSize = "sm" | "md" | "lg" | "xl";
14+
915
/**
1016
* @element ak-spinner
1117
*

0 commit comments

Comments
 (0)