Skip to content

Conversation

@kensternberg-authentik
Copy link
Collaborator

@kensternberg-authentik kensternberg-authentik commented Dec 19, 2025

elements/progress-bar:

What

This commit adapts the P5 Progress Bar to the Authentik design; encapsulated, with an XS and indeterminate progress variant.

It has a custom dark mode and some other minor customizations. To that end, the wcc file has been overriden.

Notes

Adding the spread operator to progress-bar caused me to check the other components and, sure enough, a number of them had incomplete Props types and no spread operator. I've addressed those here.

* element/ak-icon:
  Prettier has opinions.
  Added some docs.
  Prettier has opinions.
  Prettier's opinions sometimes suck.
  Prettier still has opinions.
  Added types to make Teffen happy.
  rem, not em, for the pseudo-patternfly icon sizes derivef from fontawesome.  Otherwise, the multiplicative effect is... dramatic.  Icons as big as your monitor.
  Removing unneeded references.
  Added FontAwesome icon sizes to repetoire.  Also: Prettier has opinions.
  # ak-icon
  Icon maybe final
  Initial check-in for icons.  Still needs testing.
  .
* main: (41 commits)
  Forgot to run , and now that I have a hook to do it for me, this is making it whiny.
  Fixed typo in css.
  Added comments to the wcc file.
  This commit revises the WCCSS transpiler, using the regular expression and merge algorithms recommended by the Patternfly 5 React team.
  Added wccss pass to package.json.
  Type inference FTW.
  Needed to put tools build in-line
  This commit ports the Elements' build tools to Typescript
  Cleanup.
  New css build completing.
  Crawling back to the original starting point, but this time with better tooling.
  Save point.
  This commit introduces a dark-mode controller and code.
  A working dark mode, although with some dubious decisions
  Build system revised into a more unixy pattern: each script does one thing well.
  Bump validator from 13.15.15 to 13.15.20 (#10)
  Bump vite (#9)
  First stab at the dark-mode controller; it takes orders from the central context, if there is one, but if not, it tries to determine the mode itself by looking at the user's preferences.
  Revised brand to meet a... more modern standard.
  npm trusted publisher
  ...
Merge had to be hand-repaired as it failed to build after merge.  The linting on `main`
was more stringent than what this had had before application.

* main: (41 commits)
  Added comment explaining why the initial `attachToAnchor` is run in a late animation frame after `connectedCallback()`
  admin: adjustments found during integration
  Removed default border on dialog for tooltip.  We'll manage that ourselves, using Patternfly's layout.
  Continuing to adjust for dark mode, with additions for pulling fonts past the shadowDOM.
  re-arrange the CSS to better support dark mode.
  Merge mangling.
  Something got lost in the merge.
  Update .gitignore
  Adopted many of the suggestions from @GirlBossRush
  Handling focus grabbing.
  Update src/ak-tooltip/ak-tooltip.component.ts
  Update src/ak-tooltip/ak-tooltip.component.ts
  Update src/ak-tooltip/ak-tooltip-state-machine.ts
  Not sure how that all got re-arranged like that.
  elements: lintpicking
  Added types to the state machine.
  element: ak-tooltip
  Bump glob (#36)
  Bump js-yaml from 3.14.1 to 3.14.2 (#33)
  Bump validator from 13.15.15 to 13.15.23 (#40)
  ...
# What

This commit adapts the P5 Progress Bar to the Authentik design; encapsulated, with an `XS` and `indeterminate` progress variant.

It has a custom dark mode and some other minor customizations. To that end, the wcc file has been overriden.
@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for authentik-elements-storybook ready!

Name Link
🔨 Latest commit 7be0d30
🔍 Latest deploy log https://app.netlify.com/projects/authentik-elements-storybook/deploys/69692ebd6df5ab0008dd5648
😎 Deploy Preview https://deploy-preview-48--authentik-elements-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kensternberg-authentik kensternberg-authentik marked this pull request as ready for review December 19, 2025 22:40
* main: (23 commits)
  Accepted suggestion from @GirlBossRush
  Update vitest.config.js
  Update src/ak-button/ak-button.component.ts
  Update src/ak-button/ak-button.template.ts
  Typos is dumb, part 2.
  Typos is dumb.
  Added comment explaining why href is _removed_ from an anchor when the anchor is disabled.
  Moving source-maps into devDependencies.
  I hate wresting with type uncertainty.
  We now provide the types correctly.
  NPM between the versions is a massive source of headache.
  Merge weirdness.
  Rounding out icon tests.
  Bump vite (#44)
  Bump storybook from 9.1.8 to 9.1.17 (#47)
  bump version
  Fixing the optimization set in vitest, as recommended on Github.
  Attempting to fix browser version.
  Another attempt at getting playwright to play nice.
  Adjusting test parameters.
  ...
* main: (51 commits)
  Not sure why tests are failing.
  Trying test fix.
  element/ak-timestamp: consistency pass and final check
  element/ak-divider: consistency check and test update
  element/ak-empty-state: consistency check
  Last-minute changes lead to last-minute bugs.
  elements: structural issues
  Documentation update
  elements: fix inconsistent API, UI, and DX issues
  Consistency pass: fixed some poor name choices and removed the useless interfaces.
  Applies the new vitest suite to ak-timestamp.
  OptimizeDeps is hard to get right, apparently.
  Added lit/localize to the optimizeDeps collection.
  Playwright-ifying the tests.
  Not sure how this got lost.
  element: ak-timeout
  And divider is now themable and dark-mode capable.
  Just maintainging a 'prettier' codebase.
  Updating for release.
  Empty state now has root CSS definition, making it available for customer customization.
  ...
\# What

\# Why

\# How

\# Designs

\# Test Steps

\# Other Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants