Merge pull request #8 from AnetteTaivere/explode-bugfix

karoliineh · web-flow · commit 7b7ca94dbcef · 2024-03-15T18:56:15.000+02:00
Bugfix: do not explode warnings when `group_loc` is `null`
diff --git a/src/main/java/api/messages/GoblintMessagesResult.java b/src/main/java/api/messages/GoblintMessagesResult.java
@@ -92,7 +92,7 @@ public static class Group implements MultiPiece {
          * @return A collection of AnalysisResult objects.
          */
         public List<AnalysisResult> convert(List<Tag> tags, String severity, boolean explode) {
-            return explode
+            return explode && this.group_loc != null
                     ? convertGroupExplode(tags, severity)
                     : convertGroup(tags, severity);
         }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public static class Group implements MultiPiece {`
`92`	`92`	`* @return A collection of AnalysisResult objects.`
`93`	`93`	`*/`
`94`	`94`	`public List<AnalysisResult> convert(List<Tag> tags, String severity, boolean explode) {`
`95`		`- return explode`
	`95`	`+ return explode && this.group_loc != null`
`96`	`96`	`? convertGroupExplode(tags, severity)`
`97`	`97`	`: convertGroup(tags, severity);`
`98`	`98`	`}`