Skip to content

Commit 31c74b2

Browse files
committed
Update TODOs in XsltResultOutput
1 parent e88b0e2 commit 31c74b2

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/framework/xsltResultOutput.ml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,10 @@ struct
149149
BatPrintf.fprintf f {xml|<?xml version="1.0" ?>
150150
<?xml-stylesheet type="text/xsl" href="report.xsl"?>
151151
<report>|xml};
152-
(* TODO: exclude <file> path? *)
153-
(* TODO: exclude <node>s? *)
154152
(* TODO: exclude dead files/functions? *)
155-
(* BatEnum.iter (fun b -> BatPrintf.fprintf f "<file name=\"%s\" path=\"%s\">\n%a</file>\n" (Filename.basename b) b p_funs (SH.find_all file2funs b)) (BatEnum.uniq @@ SH.keys file2funs); *)
156153
(* g2html has full path in name field *)
154+
(* for g2html we have path field for <file>, but this doesn't seem necessary *)
155+
(* for g2html we add <node>s into each <function>, but these aren't necessary because they aren't shown *)
157156
SH.iter (printXml_file f) file2funs;
158157
BatPrintf.fprintf f "</report>";
159158
)
@@ -174,7 +173,7 @@ struct
174173
BatPrintf.fprintf f {xml|<?xml version="1.0" ?>
175174
<?xml-stylesheet type="text/xsl" href="../node.xsl"?>
176175
<loc>%a</loc>|xml} (Fun.flip printXml_node n) v
177-
(* TODO: need fun in <call>? *)
176+
(* g2html adds fun attribute to <call> (inside printXml_node), but this doesn't seem to be necessary *)
178177
)
179178

180179
let write_nodes ~result_dir ~table =

0 commit comments

Comments
 (0)