Comment additionalProperties handling

Author: sim642

src/util/gobConfig.ml

@@ -182,7 +182,7 @@ struct
       begin
         try get_value (List.assoc key m) pth
         with Not_found ->
-          try get_value (List.assoc Options.defaults_additional_field m) pth
+          try get_value (List.assoc Options.defaults_additional_field m) pth (* if schema specifies additionalProperties, then use the default from that *)
           with Not_found -> raise ConfTypeError
       end
     | `List a, Index (Int i, pth) ->
@@ -227,7 +227,8 @@ struct
       match o, pth with
       | `Assoc m, Select (key,pth) ->
         let rec modify = function
-          | [] -> [(key, create_new v pth)]
+          | [] ->
+            [(key, create_new v pth)] (* create new key, validated by schema *)
           | (key', v') :: kvs when key' = key ->
             (key, set_value v v' pth) :: kvs
           | (key', v') :: kvs ->

src/util/jsonSchema.ml

@@ -95,6 +95,7 @@ let rec element_defaults ?additional_field (element: element): Yojson.Safe.t =
       | Object object_specs ->
         let additional = match additional_field, object_specs.additional_properties with
           | Some additional_field, Some additional_properties ->
+            (* create additional field with the additionalProperties default value for lookup in GobConfig *)
             [(additional_field, element_defaults ~additional_field additional_properties)]
           | _, _ ->
             []

src/util/options.ml

@@ -28,7 +28,7 @@ let schema =
 
 let require_all = JsonSchema.schema_require_all schema
 
-let defaults_additional_field = "__additional__"
+let defaults_additional_field = "__additional__" (* tihs shouldn't conflict with any actual field *)
 let defaults = JsonSchema.schema_defaults ~additional_field:defaults_additional_field schema
 
 let () =