Fix affeq analysis sparse config param and dune file

Author: kadameit

src/analyses/apron/affineEqualityAnalysis.apron.ml

@@ -14,15 +14,15 @@ include RelationAnalysis
 
 (* There are two versions of the affeq domain.
    1. Sparse without side effects
-   2. Array with side effects
+   2. Dense Array with side effects
    Default: sparse implementation
-   The array implementation with side effects of the affeq domain is used when the --enable ana.affeq.side_effects option is set *)
+   The array implementation with side effects of the affeq domain is used when the --disable ana.affeq.sparse option is set *)
 let get_domain: (module RelationDomain.RD) Lazy.t =
   lazy (
-    if GobConfig.get_bool "ana.affeq.side_effects" then
-      (module AffineEqualityDomainSideEffects.D2 (ArrayVector) (ArrayMatrix))
-    else
+    if GobConfig.get_bool "ana.affeq.sparse" then
       (module AffineEqualityDomain.D2 (SparseVector) (ListMatrix))
+    else
+      (module AffineEqualityDenseDomain.D2 (ArrayVector) (ArrayMatrix))
   )
 
 let spec_module: (module MCPSpec) Lazy.t =

src/config/options.schema.json

@@ -1203,7 +1203,7 @@
           "title": "ana.affeq",
           "type": "object",
           "properties": {
-            "side_effects": {
+            "sparse": {
               "title": "ana.affeq.sparse",
               "description": "Use sparse implementation of Affine Equality analysis (using lists). If set to false, the dense version is used (using arrays). Default is true (sparse implementation)",
               "type": "boolean",

src/dune

@@ -35,9 +35,9 @@
       (apron -> affineEqualityDomain.apron.ml)
       (-> affineEqualityDomain.no-apron.ml)
     )
-    (select affineEqualityDomainSideEffects.ml from
-      (apron -> affineEqualityDomainSideEffects.apron.ml)
-      (-> affineEqualityDomainSideEffects.no-apron.ml)
+    (select affineEqualityDenseDomain.ml from
+      (apron -> affineEqualityDenseDomain.apron.ml)
+      (-> affineEqualityDenseDomain.no-apron.ml)
     )
     (select linearTwoVarEqualityAnalysis.ml from
       (apron -> linearTwoVarEqualityAnalysis.apron.ml)

src/goblint_lib.ml

@@ -260,7 +260,7 @@ module ValueDomainQueries = ValueDomainQueries
 module RelationDomain = RelationDomain
 module ApronDomain = ApronDomain
 module AffineEqualityDomain = AffineEqualityDomain
-module AffineEqualityDomainSideEffects = AffineEqualityDomainSideEffects
+module AffineEqualityDomainDense = AffineEqualityDenseDomain
 module LinearTwoVarEqualityDomain = LinearTwoVarEqualityDomain
 
 (** {3 Concurrency} *)