Merge pull request #2359 from travisturner/tlt/empty-null-time

For nulls.Time, decode empty value as NULL

Author: sio4

binding/decoders/null_time.go

@@ -7,6 +7,15 @@ func NullTimeDecoderFn() func([]string) (interface{}, error) {
 	return func(vals []string) (interface{}, error) {
 		var ti nulls.Time
 
+		// If vals is empty, return a nulls.Time with Valid = false (i.e. NULL).
+		// The parseTime() function called below does this check as well, but
+		// because it doesn't return an error in the case where vals is empty,
+		// we have no way to determine from its response that the nulls.Time
+		// should actually be NULL.
+		if len(vals) == 0 || vals[0] == "" {
+			return ti, nil
+		}
+
 		t, err := parseTime(vals)
 		if err != nil {
 			return ti, err

binding/decoders/null_time_test.go

@@ -14,23 +14,28 @@ func Test_NullTimeCustomDecoder_Decode(t *testing.T) {
 	testCases := []struct {
 		input     string
 		expected  time.Time
+		expValid  bool
 		expectErr bool
 	}{
 		{
 			input:    "2017-01-01",
 			expected: time.Date(2017, time.January, 1, 0, 0, 0, 0, time.UTC),
+			expValid: true,
 		},
 		{
 			input:    "2018-07-13T15:34",
 			expected: time.Date(2018, time.July, 13, 15, 34, 0, 0, time.UTC),
+			expValid: true,
 		},
 		{
 			input:    "2018-20-10T30:15",
 			expected: time.Time{},
+			expValid: false,
 		},
 		{
 			input:    "",
 			expected: time.Time{},
+			expValid: false,
 		},
 	}
 
@@ -47,5 +52,6 @@ func Test_NullTimeCustomDecoder_Decode(t *testing.T) {
 		}
 
 		r.Equal(testCase.expected, nt.Time)
+		r.Equal(testCase.expValid, nt.Valid)
 	}
 }