It should choose the primary email, not the first one

[voidus]

If the user has multiple email addresses configured in github with the default one not being the first, gocd will select the first one, while the default email would be a more useful choice.

[arvindsv]

Based on a quick look, it seems to be getting the email using

github-oauth-authorization-plugin/src/main/java/cd/go/authorization/github/models/LoggedInUserInfo.java

Line 32 in 0e13b60

user = new User(gitHubUser.getLogin(), gitHubUser.getName(), gitHubUser.getEmail());

... which eventually calls this library method. Maybe you're suggesting using an email from this list? Not sure if there is a default email available.

[voidus]

I had a quick look too, and it seems to me that the github api shows which email addresses are primary[1], which is handled in the GHEmail class[2], which in turn is only used in GHMyself[3] and not in GHUser[4] or the common superclass GHPerson[5], where getEmail returns a String.

As String getEmails() is deprecated on GHMyself, I assume using the GHEmail class is in-progress, thus this issue depends in GHUser (or GHPerson) returning GHEmail.

[1] https://developer.github.com/v3/users/emails/
[2] https://github.com/kohsuke/github-api/search?q=primary&unscoped_q=primary
[3] https://github.com/kohsuke/github-api/search?q=GHEmail&unscoped_q=GHEmail
[4] https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHUser.java
[5] https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHPerson.java