Skip to content

Commit ef72b9f

Browse files
committed
Merge remote-tracking branch 'upstream/master' into gocd-master
# Conflicts: # README.md
2 parents 4dcc245 + 53b0487 commit ef72b9f

30 files changed

+640
-265
lines changed

.github/workflows/maven.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
cache: maven
3939

4040
- name: Build with Maven
41-
run: mvn -B install -Djruby.version=${{ matrix.jruby_version }}
41+
run: ./mvnw -B install -Djruby.version=${{ matrix.jruby_version }}
4242

4343
# Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
4444
- name: Update dependency graph
@@ -79,7 +79,7 @@ jobs:
7979
cache: maven
8080

8181
- name: Setup JRuby
82-
uses: ruby/setup-ruby@a9bfc2ecf3dd40734a9418f89a7e9d484c32b990 # v1.248.0
82+
uses: ruby/setup-ruby@2a7b30092b0caf9c046252510f9273b4875f3db9 # v1.254.0
8383
with:
8484
ruby-version: jruby-${{ matrix.jruby_version }}
8585
bundler-cache: 'false' # Need to install later so we can vary from Gemfile.lock as required for JRuby version compatibility
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing,
12+
# software distributed under the License is distributed on an
13+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
# KIND, either express or implied. See the License for the
15+
# specific language governing permissions and limitations
16+
# under the License.
17+
wrapperVersion=3.3.2
18+
distributionType=only-script
19+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.8/apache-maven-3.8.8-bin.zip

README.md

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,14 @@
11
# JRuby-Rack
22

3+
[![Gem Version](https://badge.fury.io/rb/jruby-rack.png)][8]
4+
[![Build Status](https://github.com/jruby/jruby-rack/actions/workflows/maven.yml/badge.svg)][9]
5+
36
JRuby-Rack is a lightweight adapter for the Java Servlet environment that allows
47
any (Ruby) Rack-based application to run unmodified in a Java Servlet container.
58
JRuby-Rack supports Rails as well as any Rack-compatible Ruby web framework.
69

710
For more information on Rack, visit http://rack.github.io/.
811

9-
**This README (master) targets JRuby-Rack 1.3. Please use the [1.2-stable](https://github.com/jruby/jruby-rack/tree/1.2-stable) or
10-
[1.1-stable](https://github.com/jruby/jruby-rack/tree/1.1-stable) branches for
11-
current stable releases.**
12-
13-
[![Gem Version](https://badge.fury.io/rb/jruby-rack.png)][8]
14-
[![Build Status](https://github.com/jruby/jruby-rack/actions/workflows/maven.yml/badge.svg)][9]
15-
1612
## gocd-contrib Fork
1713

1814
This fork is intended as temporary to validate jruby-rack changes for use in GoCD with quicker turnaround time. The goal is to
@@ -30,22 +26,14 @@ dependencies {
3026
}
3127
```
3228

33-
34-
3529
## Compatibility
3630

37-
JRuby-Rack 1.3.x
38-
- aims to be compatible with JRuby 9.4 -> 10.0 and Java 11+
39-
- supports any container compatible with Java Servlet 4.0 API
40-
41-
JRuby-Rack 1.2.x
42-
- compatible with JRuby 9.3 -> 9.4 and their supported JDK versions
43-
- supports any container compatible with Java Servlet 3.0 API
44-
45-
JRuby-Rack 1.1.x
46-
- aims to be compatible with JRuby >= 1.6.4 (used successfully through JRuby 9.4)
47-
- supports any container compatible with Java Servlet 2.5 API (JEE 5)
48-
31+
| JRuby-Rack Version | Status | JRuby Compat | Java Compat | Target Servlet API | Target Java EE | Notes |
32+
|--------------------------------------------------------------|------------|--------------|-------------|--------------------|----------------|---------------------------------------------------|
33+
| 1.4.x (_planned_) | Dev | 9.4 → 10.0 | Java 17+ | 5.0 | Jakarta EE 9 | |
34+
| 1.3.x (master, _unreleased_) | Dev | 9.4 → 10.0 | Java 11+ | 4.0 | Java EE 8 | |
35+
| [1.2.x](https://github.com/jruby/jruby-rack/tree/1.2-stable) | Maintained | 9.3 → 9.4 | Java 8+ | 3.0 | Java EE 6 | Servlet 3.1 → 4.0 tested OK with some containers. |
36+
| [1.1.x](https://github.com/jruby/jruby-rack/tree/1.1-stable) | EOL | 1.6 → 9.4 | Java 8+ | 2.5 | Java EE 5 | Servlet 3.0 → 4.0 tested OK with some containers. |
4937

5038
## Getting Started
5139

@@ -356,7 +344,7 @@ package and push the .jar every time a commit changes a source file).
356344

357345
## Releasing
358346

359-
* Make sure auth is configured for "ossrh" repository ID in your .m2/settings.xml
347+
* Make sure auth is configured for "central" repository ID in your .m2/settings.xml
360348
* Update the version in src/main/ruby/jruby/rack/version.rb to the release version
361349
* mvn release:prepare
362350
* mvn release:perform (possibly with -DuseReleaseProfile=false due to Javadoc doclint failures for now)

Rakefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ directory 'target/classes'
3838

3939
desc "Compile classes"
4040
task(:compile => 'target/classes') do
41-
sh "mvn compile #{ENV['JRUBY_VERSION'] ? "-Djruby.version=#{ENV['JRUBY_VERSION']}" : ""}"
41+
sh "./mvnw compile #{ENV['JRUBY_VERSION'] ? "-Djruby.version=#{ENV['JRUBY_VERSION']}" : ""}"
4242
end
4343

4444
directory 'target/test-classes'
4545

4646
desc "Compile test classes"
4747
task(:test_prepare => ['target/classes', 'target/test-classes']) do
48-
sh "mvn test-compile #{ENV['JRUBY_VERSION'] ? "-Djruby.version=#{ENV['JRUBY_VERSION']}" : ""}"
48+
sh "./mvnw test-compile #{ENV['JRUBY_VERSION'] ? "-Djruby.version=#{ENV['JRUBY_VERSION']}" : ""}"
4949
end
5050

5151
desc "Unpack the rack gem"
@@ -98,7 +98,7 @@ task :test_resources => ["target/test-classes"]
9898
namespace :resources do
9999
desc "Copy (and generate) resources"
100100
task :copy => :resources do
101-
sh 'mvn process-resources -Dmdep.skip=true'
101+
sh './mvnw process-resources -Dmdep.skip=true'
102102
end
103103
desc "Generate test resources"
104104
task :test => :test_resources
@@ -208,7 +208,7 @@ task :release_checks do
208208
" git push origin :#{GEM_VERSION}" if ok
209209
end
210210

211-
pom_version = `mvn help:evaluate -Dexpression=project.version`.
211+
pom_version = `./mvnw help:evaluate -Dexpression=project.version`.
212212
split("\n").reject { |line| line =~ /[INFO]/ }.first.chomp
213213
if pom_version =~ /dev|SNAPSHOT/
214214
fail "Can't release a dev/snapshot version.\n" +
@@ -218,7 +218,7 @@ task :release_checks do
218218
unless pom_version.sub(/\-(\D+\w*)/, '.\1') == GEM_VERSION
219219
fail "Can't release because pom.xml version (#{pom_version}) is different than " +
220220
"jruby/rack/version.rb (#{GEM_VERSION}).\n" +
221-
"Please run `mvn install' to bring the two files in sync."
221+
"Please run `./mvnw install' to bring the two files in sync."
222222
end
223223

224224
puts "release #{GEM_VERSION} looks ready to go ..."
@@ -229,7 +229,7 @@ task :release => [:release_checks, :clean] do
229229
args = ''
230230
args << "-Dgpg.keyname=#{ENV['GPG_KEYNAME']} " if ENV['GPG_KEYNAME']
231231

232-
sh "mvn -Prelease #{args} -DupdateReleaseInfo=true clean deploy"
232+
sh "./mvnw -Prelease #{args} -DupdateReleaseInfo=true clean deploy"
233233

234234
sh "git tag #{GEM_VERSION}"
235235

0 commit comments

Comments
 (0)