#59 fix enabling init.d services of additional agents

Author: tomzo

providers/agent.rb

@@ -17,10 +17,13 @@
     owner    new_resource.user
     group    new_resource.group
   end
-  # package manages the init.d script so we will not
-  # and we will expect that init.d scripts are already installed
-  link "/etc/init.d/#{agent_name}" do
-    to "/etc/init.d/go-agent"
+  # package manages the init.d/go-agent script so cookbook should not.
+  bash "setup init.d for #{agent_name}" do
+    code <<-EOH
+    cp /etc/init.d/go-agent /etc/init.d/#{agent_name}
+    sed -i 's/# Provides: go-agent$/# Provides: #{agent_name}/g' /etc/init.d/#{agent_name}
+    EOH
+    only_if "grep -q '# Provides: go-agent$' /etc/init.d/#{agent_name}"
     not_if { agent_name == 'go-agent' }
   end
   link "/usr/share/#{agent_name}" do

spec/go_agent_lwrp_spec.rb

@@ -10,6 +10,11 @@
     end
     run.converge(described_recipe)
   end
+  before do
+    stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    stub_command("grep -q '# Provides: go-agent$' /etc/init.d/my-go-agent").and_return(false)
+  end
+
   it_behaves_like :agent_linux_install
 
   it 'creates my-go-agent chef resource' do

spec/go_agent_spec.rb

@@ -54,6 +54,9 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    end
     it_behaves_like :agent_recipe
     it_behaves_like :apt_repository_recipe
     it 'installs go-agent package' do
@@ -70,6 +73,9 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    end
     it_behaves_like :agent_recipe
     it_behaves_like :yum_repository_recipe
     it 'installs go-agent package' do
@@ -90,6 +96,10 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent-1").and_return(true)
+    end
     it_behaves_like :agent_recipe
     it_behaves_like :apt_repository_recipe
     it 'installs go-agent package' do
@@ -100,9 +110,7 @@
       expect(chef_run).to create_gocd_agent('go-agent-1')
     end
     it 'creates init.d script to start additional agent' do
-      expect(chef_run).to create_link('/etc/init.d/go-agent-1').with(
-        to: '/etc/init.d/go-agent'
-      )
+      expect(chef_run).to run_bash('setup init.d for go-agent-1')
     end
     it 'links /usr/share/go-agent script' do
       expect(chef_run).to create_link('/usr/share/go-agent-1').with(
@@ -152,6 +160,9 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    end
     it_behaves_like :agent_recipe
     it 'downloads go-agent .deb from remote URL' do
       expect(chef_run).to create_remote_file('go-agent-15.2.0-2248.deb').with(
@@ -172,6 +183,9 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    end
     it_behaves_like :agent_recipe
     it 'downloads go-agent .rpm from remote URL' do
       expect(chef_run).to create_remote_file('go-agent-15.2.0-2248.noarch.rpm').with(
@@ -199,6 +213,9 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    end
     it_behaves_like :agent_recipe
     it 'includes apt recipe' do
       expect(chef_run).to include_recipe('apt')
@@ -226,6 +243,9 @@
       end
       run.converge(described_recipe)
     end
+    before do
+      stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+    end
     it_behaves_like :agent_recipe
     it 'includes yum recipe' do
       expect(chef_run).to include_recipe('yum')

spec/shared_examples.rb

@@ -1,4 +1,7 @@
 shared_examples_for :apt_repository_recipe do
+  before do
+    stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+  end
   it 'includes apt recipe' do
     expect(chef_run).to include_recipe('apt')
   end
@@ -11,6 +14,9 @@
   end
 end
 shared_examples_for :yum_repository_recipe do
+  before do
+    stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+  end
   it 'includes yum recipe' do
     expect(chef_run).to include_recipe('yum')
   end
@@ -22,6 +28,9 @@
   end
 end
 shared_examples_for :agent_linux_install do
+  before do
+    stub_command("grep -q '# Provides: go-agent$' /etc/init.d/go-agent").and_return(false)
+  end
   it 'includes java recipe' do
     expect(chef_run).to include_recipe('java::default')
   end