-
Notifications
You must be signed in to change notification settings - Fork 138
Open
Labels
Type: EnhancementImprovements existing features or codeImprovements existing features or code
Description
SQL_CALC_FOUND_ROWS is deprecated in MySQL. Instead, wrap calls with a SELECT COUNT() query or refactor to have COUNT() in the main query, depending.
We'll want to search for all instances of get_found_results or SQL_CALC_FOUND_ROWS in the codebase to replace with COUNT(*) instead.
A new count_only param was introduced specifically for the student query in #3075 . We may want to add a new get_count() or something to make it clearer in the code we're not using the SQL_CALC_FOUND_ROWS value.
Plan:
- Find all instances of
SQL_CALC_FOUND_ROWSandget_found_results() - Change the query to have COUNT(*) in the main SELECT clause, wrap in a new
SELECT COUNT(*) FROM ( ... original query ... ), or add thecount_onlyparam to the query object being created. - Remove/deprecate adding of SQL_CALC_FOUND_ROWS to any queries
- Test all changes return the correct counts
Metadata
Metadata
Assignees
Labels
Type: EnhancementImprovements existing features or codeImprovements existing features or code
Type
Projects
Status
To do