Tests: Optional params must follow required params.

peterwilsoncc · peterwilsoncc · commit 851973a39bb1 · 2025-12-03T10:34:22.000+11:00
diff --git a/tests/integration/API/CacheableAPIBaseTest.php b/tests/integration/API/CacheableAPIBaseTest.php
@@ -267,7 +267,7 @@ public function provider_get_request_transient_key(): array {
 	 *
 	 * @throws ReflectionException
 	 */
-	public function test_is_request_cacheable( bool $is_cacheable, $filter_value = null, bool $expected ) {
+	public function test_is_request_cacheable( bool $is_cacheable, $filter_value, bool $expected ) {
 
 		$api = $this->get_new_api_instance_with_request( $this->get_new_request_instance( $is_cacheable ) );
 
@@ -313,7 +313,7 @@ public function provider_is_request_cacheable(): array {
 	 *
 	 * @throws ReflectionException
 	 */
-	public function test_get_request_cache_lifetime( int $lifetime, $filter_value = null, int $expected ) {
+	public function test_get_request_cache_lifetime( int $lifetime, $filter_value, int $expected ) {
 
 		$api = $this->get_new_api_instance_with_request( $this->get_new_request_instance()->set_cache_lifetime( $lifetime ) );
 

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ public function provider_get_request_transient_key(): array {`
`267`	`267`	`*`
`268`	`268`	`* @throws ReflectionException`
`269`	`269`	`*/`
`270`		`- public function test_is_request_cacheable( bool $is_cacheable, $filter_value = null, bool $expected ) {`
	`270`	`+ public function test_is_request_cacheable( bool $is_cacheable, $filter_value, bool $expected ) {`
`271`	`271`
`272`	`272`	`$api = $this->get_new_api_instance_with_request( $this->get_new_request_instance( $is_cacheable ) );`
`273`	`273`
`@@ -313,7 +313,7 @@ public function provider_is_request_cacheable(): array {`
`313`	`313`	`*`
`314`	`314`	`* @throws ReflectionException`
`315`	`315`	`*/`
`316`		`- public function test_get_request_cache_lifetime( int $lifetime, $filter_value = null, int $expected ) {`
	`316`	`+ public function test_get_request_cache_lifetime( int $lifetime, $filter_value, int $expected ) {`
`317`	`317`
`318`	`318`	`$api = $this->get_new_api_instance_with_request( $this->get_new_request_instance()->set_cache_lifetime( $lifetime ) );`
`319`	`319`