Handle globs using Windows separators (#547)

* Handle globs using Windows separators

Glob patterns are being generated with Windows separators when running `gasket create` on Windows which causes `glob` to not find any files. Fix up pattern before passing to `glob`.

* fix: lock file

---------

Co-authored-by: Andrew Gerard <agerard@godaddy.com>

Author: jpage-godaddy

packages/gasket-cli/CHANGELOG.md

@@ -1,5 +1,7 @@
 # `@gasket/cli`
 
+- Fix generation of files on Windows during gasket create when plugins use globs containing Windows separators 
+
 ### 6.34.6
 
 - Retain destOverride from provided create context ([#480])

packages/gasket-cli/package.json

@@ -28,6 +28,7 @@
     "test:integration:coverage": "nyc --reporter=text --reporter=json-summary --all run-s test:integration",
     "test:mocha": "mocha --require test/setup.js --recursive \"test/**/*.test.js\"",
     "test:unit": "mocha --require test/setup.js --recursive \"test/unit/**/*.test.js\"",
+    "test:unit:watch": "npm run test:unit -- --watch",
     "test:unit:coverage": "nyc --reporter=text --reporter=lcov --all run-s test:unit"
   },
   "repository": {

packages/gasket-cli/src/scaffold/actions/generate-files.js

@@ -79,6 +79,7 @@ async function getDescriptors(context) {
     await Promise.all(files.globSets.map(async set => {
       const { globs, source } = set;
       const matches = await Promise.all(globs.map(async pattern => {
+        pattern = splitSep(pattern).join('/');  // Glob uses / for all OS's
         const srcPaths = await glob(pattern, { nodir: true });
         return assembleDescriptors(dest, source.name, pattern, srcPaths);
       }));

packages/gasket-cli/test/unit/scaffold/actions/generate-files.test.js

@@ -276,6 +276,17 @@ describe('generateFiles', () => {
       assume(results).lengthOf(5);
     });
 
+    it('works with Windows path separators', async function () {
+      mockContext.files.globSets = [{
+        globs: [fixtures + '\\generator\\**\\*'],
+        source: {
+          name: '@gasket/plugin-example'
+        }
+      }];
+      const results = await generateFiles._getDescriptors(mockContext);
+      assume(results).lengthOf(5);
+    });
+
     it('reduces duplicates with overrides prop', async function () {
       mockContext.files.globSets = [{
         globs: [fixtures + '/generator/*'],
@@ -333,15 +344,15 @@ describe('generateFiles', () => {
         // mixed slashes for testing
         'C:\\path\\to/my-app',
         from,
-        'C:\\gasket-cli\\test\\fixtures/rel/../generator/*',
+        'C:/gasket-cli/test/fixtures/rel/../generator/*',
         [
           'C:\\gasket-cli\\test\\fixtures\\generator\\file-a.md',
           // glob may return with forward-slash
           'C:/gasket-cli/test/fixtures/generator/file-b.md'
         ]
       );
       assume(results[0]).objectContaining({
-        pattern: 'C:\\gasket-cli\\test\\fixtures/rel/../generator/*',
+        pattern: 'C:/gasket-cli/test/fixtures/rel/../generator/*',
         base: 'C:\\gasket-cli\\test\\fixtures\\generator',
         srcFile: sinon.match('C:\\gasket-cli\\test\\fixtures\\generator\\file-a.md'),
         targetFile: 'C:\\path\\to\\my-app\\file-a.md',