Skip to content

Commit 2e262c4

Browse files
committed
Null check channel message params before doing anything else
1 parent 3acd9ac commit 2e262c4

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

Client/ChatWorker.cs

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -333,24 +333,28 @@ public void QueueChatLeave(string playerName, string channelName)
333333

334334
public void QueueChannelMessage(string fromPlayer, string channelName, string channelMessage)
335335
{
336-
ChannelEntry ce = new ChannelEntry();
337-
ce.fromPlayer = fromPlayer;
338-
ce.channel = channelName;
339-
ce.message = channelMessage;
340-
newChannelMessages.Enqueue(ce);
341-
if (!display)
336+
// Check if any of these is null before doing anything else
337+
if (!string.IsNullOrEmpty(fromPlayer) && !string.IsNullOrEmpty(channelMessage))
342338
{
343-
if (ce.fromPlayer != consoleIdentifier)
344-
{
345-
chatButtonHighlighted = true;
346-
}
347-
if (ce.channel != "")
339+
ChannelEntry ce = new ChannelEntry();
340+
ce.fromPlayer = fromPlayer;
341+
ce.channel = channelName;
342+
ce.message = channelMessage;
343+
newChannelMessages.Enqueue(ce);
344+
if (!display)
348345
{
349-
ScreenMessages.PostScreenMessage(ce.fromPlayer + " -> #" + ce.channel + ": " + ce.message, 5f, ScreenMessageStyle.UPPER_LEFT);
350-
}
351-
else
352-
{
353-
ScreenMessages.PostScreenMessage(ce.fromPlayer + " -> #Global : " + ce.message, 5f, ScreenMessageStyle.UPPER_LEFT);
346+
if (ce.fromPlayer != consoleIdentifier)
347+
{
348+
chatButtonHighlighted = true;
349+
}
350+
if (!string.IsNullOrEmpty(ce.channel))
351+
{
352+
ScreenMessages.PostScreenMessage(ce.fromPlayer + " -> #" + ce.channel + ": " + ce.message, 5f, ScreenMessageStyle.UPPER_LEFT);
353+
}
354+
else
355+
{
356+
ScreenMessages.PostScreenMessage(ce.fromPlayer + " -> #Global : " + ce.message, 5f, ScreenMessageStyle.UPPER_LEFT);
357+
}
354358
}
355359
}
356360
}

0 commit comments

Comments
 (0)