Skip to content

Commit 3564cfe

Browse files
authored
Merge pull request #1339 from godot-rust/feature/godot-4.5
Godot 4.5 API level
2 parents 7706d0b + 9b4321c commit 3564cfe

File tree

13 files changed

+44
-19
lines changed

13 files changed

+44
-19
lines changed

.github/workflows/full-ci.yml

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -255,11 +255,11 @@ jobs:
255255
godot-binary: godot.macos.editor.dev.double.x86_64
256256
rust-extra-args: --features godot/api-custom,godot/double-precision
257257

258-
- name: macos-x86-4.3
258+
- name: macos-x86-4.4
259259
os: macos-13
260-
artifact-name: macos-x86-4.3
260+
artifact-name: macos-x86-4.4
261261
godot-binary: godot.macos.editor.dev.x86_64
262-
godot-prebuilt-patch: '4.3'
262+
godot-prebuilt-patch: '4.4'
263263

264264
- name: macos-arm
265265
os: macos-latest
@@ -274,11 +274,11 @@ jobs:
274274
# godot-binary: godot.macos.editor.dev.double.arm64
275275
# rust-extra-args: --features godot/api-custom,godot/double-precision
276276

277-
- name: macos-arm-4.3
277+
- name: macos-arm-4.4
278278
os: macos-latest
279-
artifact-name: macos-arm-4.3
279+
artifact-name: macos-arm-4.4
280280
godot-binary: godot.macos.editor.dev.arm64
281-
godot-prebuilt-patch: '4.3'
281+
godot-prebuilt-patch: '4.4'
282282

283283
# Windows
284284

@@ -294,11 +294,11 @@ jobs:
294294
godot-binary: godot.windows.editor.dev.double.x86_64.exe
295295
rust-extra-args: --features godot/api-custom,godot/double-precision
296296

297-
- name: windows-4.3
297+
- name: windows-4.4
298298
os: windows-latest
299-
artifact-name: windows-4.3
299+
artifact-name: windows-4.4
300300
godot-binary: godot.windows.editor.dev.x86_64.exe
301-
godot-prebuilt-patch: '4.3'
301+
godot-prebuilt-patch: '4.4'
302302

303303
# Linux
304304

@@ -349,25 +349,34 @@ jobs:
349349
# Linux compat:
350350
# No hot-reload before 4.4, as the Godot project is 4.4+.
351351

352+
- name: linux-4.5
353+
os: ubuntu-22.04
354+
artifact-name: linux-4.5
355+
godot-binary: godot.linuxbsd.editor.dev.x86_64
356+
#godot-prebuilt-patch: '4.5'
357+
hot-reload: stable
358+
352359
- name: linux-4.4
353360
os: ubuntu-22.04
354361
artifact-name: linux-4.4
355362
godot-binary: godot.linuxbsd.editor.dev.x86_64
356363
godot-prebuilt-patch: '4.4'
357-
hot-reload: stable
364+
hot-reload: api-4-4
358365

359366
- name: linux-4.3
360367
os: ubuntu-22.04
361368
artifact-name: linux-4.3
362369
godot-binary: godot.linuxbsd.editor.dev.x86_64
363370
godot-prebuilt-patch: '4.3'
371+
hot-reload: api-4-3
364372

365373
# Can be disabled in the future (already covered by memcheck). For now kept on to differentiate quicker.
366374
- name: linux-4.2
367375
os: ubuntu-22.04
368376
artifact-name: linux-4.2
369377
godot-binary: godot.linuxbsd.editor.dev.x86_64
370378
godot-prebuilt-patch: '4.2.2'
379+
hot-reload: api-4-2
371380

372381
# Memory checks: special Godot binaries compiled with AddressSanitizer/LeakSanitizer to detect UB/leaks.
373382
# See also https://rustc-dev-guide.rust-lang.org/sanitizers.html.

.github/workflows/minimal-ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,11 @@ jobs:
187187

188188
# Linux compat
189189

190+
- name: linux-4.5
191+
os: ubuntu-22.04
192+
artifact-name: linux-4.5
193+
godot-binary: godot.linuxbsd.editor.dev.x86_64
194+
190195
- name: linux-4.4
191196
os: ubuntu-22.04
192197
artifact-name: linux-4.4

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ members = [
1919
# regular dependencies. Sort alphabetically within each section; comments about a dependency come on the section header.
2020
[workspace.dependencies]
2121
# Related to godot-rust.
22-
gdextension-api = { version = "0.2.2", git = "https://github.com/godot-rust/godot4-prebuilt", branch = "releases" }
22+
gdextension-api = { version = "0.3.0", git = "https://github.com/godot-rust/godot4-prebuilt", branch = "release-v0.3" }
2323

2424
# Main library features.
2525
glam = { version = "0.30", features = ["debug-glam-assert"] }

godot-bindings/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ api-4-2-1 = []
2424
api-4-2-2 = []
2525
api-4-3 = []
2626
api-4-4 = []
27+
api-4-5 = []
2728
# ]]
2829

2930
default = []

godot-bindings/build.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ fn main() {
2222
if cfg!(feature = "api-4-2-2") { count += 1; }
2323
if cfg!(feature = "api-4-3") { count += 1; }
2424
if cfg!(feature = "api-4-4") { count += 1; }
25+
if cfg!(feature = "api-4-5") { count += 1; }
2526
// ]]
2627

2728
assert!(count <= 1, "ERROR: at most one `api-*` feature can be enabled");

godot-bindings/src/godot_json.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ use crate::{GodotVersion, StopWatch};
2929
// [version-sync] [[
3030
// [include] current.minor
3131
// [line] use gdextension_api::version_$snakeVersion::load_gdextension_header_h as load_latest_gdextension_headers;
32-
use gdextension_api::version_4_4::load_gdextension_header_h as load_latest_gdextension_headers;
32+
use gdextension_api::version_4_5::load_gdextension_header_h as load_latest_gdextension_headers;
3333
// ]]
3434

3535
/// A minimal version of deserialized JsonExtensionApi that includes only the header.

godot-bindings/src/import.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ pub const ALL_VERSIONS: &[(u8, u8, u8)] = &[
2121
(4, 3, 0),
2222
(4, 4, 0),
2323
(4, 5, 0),
24+
(4, 6, 0),
2425
// ]]
2526
];
2627

@@ -36,6 +37,8 @@ pub use gdextension_api::version_4_2_2 as prebuilt;
3637
pub use gdextension_api::version_4_3 as prebuilt;
3738
#[cfg(feature = "api-4-4")]
3839
pub use gdextension_api::version_4_4 as prebuilt;
40+
#[cfg(feature = "api-4-5")]
41+
pub use gdextension_api::version_4_5 as prebuilt;
3942
// ]]
4043

4144
// If none of the api-* features are provided, use default prebuilt version (typically latest Godot stable release).
@@ -50,12 +53,13 @@ pub use gdextension_api::version_4_4 as prebuilt;
5053
feature = "api-4-2-2",
5154
feature = "api-4-3",
5255
feature = "api-4-4",
56+
feature = "api-4-5",
5357
feature = "api-custom",
5458
feature = "api-custom-json",
5559
)))]
5660
// ]]
5761
// [version-sync] [[
5862
// [include] current.minor
5963
// [line] pub use gdextension_api::version_$snakeVersion as prebuilt;
60-
pub use gdextension_api::version_4_4 as prebuilt;
64+
pub use gdextension_api::version_4_5 as prebuilt;
6165
// ]]

godot-core/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ api-4-2-1 = ["godot-ffi/api-4-2-1"]
3535
api-4-2-2 = ["godot-ffi/api-4-2-2"]
3636
api-4-3 = ["godot-ffi/api-4-3"]
3737
api-4-4 = ["godot-ffi/api-4-4"]
38+
api-4-5 = ["godot-ffi/api-4-5"]
3839
# ]]
3940

4041
[dependencies]

godot-core/src/builtin/string/string_name.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,9 @@ impl StringName {
156156
/// [`Node::set_name()`][crate::classes::Node::set_name] takes `GString`, let's pass a `StringName`:
157157
/// ```no_run
158158
/// # use godot::prelude::*;
159-
/// let name = StringName::from("my cool node");
160-
///
161-
/// let mut node = Node::new_alloc();
162-
/// node.set_name(name.arg());
159+
/// let needle = StringName::from("str");
160+
/// let haystack = GString::from("a long string");
161+
/// let found = haystack.find(needle.arg());
163162
/// ```
164163
}
165164

godot-ffi/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ api-4-2-1 = ["godot-bindings/api-4-2-1"]
2727
api-4-2-2 = ["godot-bindings/api-4-2-2"]
2828
api-4-3 = ["godot-bindings/api-4-3"]
2929
api-4-4 = ["godot-bindings/api-4-4"]
30+
api-4-5 = ["godot-bindings/api-4-5"]
3031
# ]]
3132

3233
[dependencies]

0 commit comments

Comments
 (0)