Skip to content

Commit 6113b0b

Browse files
PgBielBromeon
authored andcommitted
undo godot-cell feature
since it's only used for tests
1 parent ebf0a38 commit 6113b0b

File tree

4 files changed

+1
-38
lines changed

4 files changed

+1
-38
lines changed

godot-cell/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ homepage = "https://godot-rust.github.io"
1212

1313
[features]
1414
proptest = ["dep:proptest"]
15-
experimental-wasm-nothreads = []
1615

1716
[dependencies]
1817
proptest = { workspace = true, optional = true }

godot-cell/tests/mock/blocking.rs

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ impl MyClass {
4040
///
4141
/// This should not cause borrow failures and should not lead to deadlocks.
4242
#[test]
43-
#[cfg_attr(
44-
feature = "experimental-wasm-nothreads",
45-
ignore = "Threading not available"
46-
)]
4743
fn calls_parallel() {
4844
use std::thread;
4945

@@ -76,10 +72,6 @@ fn calls_parallel() {
7672
/// Runs each method several times in a row. This should reduce the non-determinism that comes from
7773
/// scheduling of threads.
7874
#[test]
79-
#[cfg_attr(
80-
feature = "experimental-wasm-nothreads",
81-
ignore = "Threading not available"
82-
)]
8375
fn calls_parallel_many_serial() {
8476
use std::thread;
8577

@@ -114,10 +106,6 @@ fn calls_parallel_many_serial() {
114106
/// Runs all the tests several times. This is different from [`calls_parallel_many_serial`] as that calls the
115107
/// methods like AAA...BBB...CCC..., whereas this interleaves the methods like ABC...ABC...ABC...
116108
#[test]
117-
#[cfg_attr(
118-
feature = "experimental-wasm-nothreads",
119-
ignore = "Threading not available"
120-
)]
121109
fn calls_parallel_many_parallel() {
122110
use std::thread;
123111

@@ -154,10 +142,6 @@ fn calls_parallel_many_parallel() {
154142
/// a) Thread A holds mutable reference AND thread B holds no references.
155143
/// b) One or more threads hold shared references AND thread A holds no references
156144
#[test]
157-
#[cfg_attr(
158-
feature = "experimental-wasm-nothreads",
159-
ignore = "Threading not available"
160-
)]
161145
fn non_blocking_reborrow() {
162146
use std::thread;
163147
let instance_id = MyClass::init();
@@ -188,10 +172,6 @@ fn non_blocking_reborrow() {
188172
/// This verifies that the thread which initialized the `GdCell` does not panic when it attempts to mutably borrow while there is already a
189173
/// shared borrow on an other thread.
190174
#[test]
191-
#[cfg_attr(
192-
feature = "experimental-wasm-nothreads",
193-
ignore = "Threading not available"
194-
)]
195175
fn no_mut_panic_on_main() {
196176
use std::thread;
197177
let instance_id = MyClass::init();

godot-cell/tests/mock/panicking.rs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ fn all_calls_work() {
5858

5959
/// Run each method both from the main thread and a newly created thread.
6060
#[test]
61-
#[cfg_attr(
62-
feature = "experimental-wasm-nothreads",
63-
ignore = "Threading not available"
64-
)]
6561
fn calls_different_thread() {
6662
use std::thread;
6763

@@ -91,10 +87,6 @@ fn calls_different_thread() {
9187
/// if the first call failed, so then we know the integer was incremented by 0. Otherwise, we at least know
9288
/// the range of values that it can be incremented by.
9389
#[test]
94-
#[cfg_attr(
95-
feature = "experimental-wasm-nothreads",
96-
ignore = "Threading not available"
97-
)]
9890
fn calls_parallel() {
9991
use std::thread;
10092

@@ -129,10 +121,6 @@ fn calls_parallel() {
129121
/// Runs each method several times in a row. This should reduce the non-determinism that comes from
130122
/// scheduling of threads.
131123
#[test]
132-
#[cfg_attr(
133-
feature = "experimental-wasm-nothreads",
134-
ignore = "Threading not available"
135-
)]
136124
fn calls_parallel_many_serial() {
137125
use std::thread;
138126

@@ -169,10 +157,6 @@ fn calls_parallel_many_serial() {
169157
/// Runs all the tests several times. This is different from [`calls_parallel_many_serial`] as that calls the
170158
/// methods like AAA...BBB...CCC..., whereas this interleaves the methods like ABC...ABC...ABC...
171159
#[test]
172-
#[cfg_attr(
173-
feature = "experimental-wasm-nothreads",
174-
ignore = "Threading not available"
175-
)]
176160
fn calls_parallel_many_parallel() {
177161
use std::thread;
178162

godot-core/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ codegen-lazy-fptrs = [
2222
double-precision = ["godot-codegen/double-precision"]
2323
experimental-godot-api = ["godot-codegen/experimental-godot-api"]
2424
experimental-threads = ["godot-ffi/experimental-threads", "godot-codegen/experimental-threads"]
25-
experimental-wasm-nothreads = ["godot-ffi/experimental-wasm-nothreads", "godot-cell/experimental-wasm-nothreads"]
25+
experimental-wasm-nothreads = ["godot-ffi/experimental-wasm-nothreads"]
2626
debug-log = ["godot-ffi/debug-log"]
2727
trace = []
2828

0 commit comments

Comments
 (0)