Skip to content

Commit 7981d80

Browse files
committed
Notes about clippy usage in check.sh and CI
1 parent 42b0253 commit 7981d80

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

.github/workflows/full-ci.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,15 @@ jobs:
7979
# Note: could use `-- --no-deps` to not lint dependencies, however it doesn't really speed up and also skips deps in workspace.
8080
- name: "Check clippy"
8181
run: |
82-
cargo clippy --all-targets $GDEXT_FEATURES ${{ matrix.rust-extra-args }} -- \
83-
-D clippy::suspicious -D clippy::style -D clippy::complexity -D clippy::perf \
84-
-D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented -D warnings
82+
cargo clippy --all-targets $GDEXT_FEATURES -- \
83+
-D clippy::suspicious \
84+
-D clippy::style \
85+
-D clippy::complexity \
86+
-D clippy::perf \
87+
-D clippy::dbg_macro \
88+
-D clippy::todo \
89+
-D clippy::unimplemented \
90+
-D warnings
8591
8692
unit-test:
8793
name: unit-test (${{ matrix.name }}${{ matrix.rust-special }})

.github/workflows/minimal-ci.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,15 @@ jobs:
8383

8484
- name: "Check clippy"
8585
run: |
86-
cargo clippy --all-targets $GDEXT_FEATURES ${{ matrix.rust-extra-args }} -- \
87-
-D clippy::suspicious -D clippy::style -D clippy::complexity -D clippy::perf \
88-
-D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented -D warnings
86+
cargo clippy --all-targets $GDEXT_FEATURES -- \
87+
-D clippy::suspicious \
88+
-D clippy::style \
89+
-D clippy::complexity \
90+
-D clippy::perf \
91+
-D clippy::dbg_macro \
92+
-D clippy::todo \
93+
-D clippy::unimplemented \
94+
-D warnings
8995
9096
9197
unit-test:

check.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ function cmd_dok() {
158158
# Argument parsing
159159
################################################################################
160160

161-
# By default, disable `codegen-full` to reduce compile times and prevent flip-flopping
162-
# between `itest` compilations and `check.sh` runs.
161+
# By default, disable `codegen-full` to reduce compile times and prevent flip-flopping between
162+
# `itest` compilations and `check.sh` runs. Note that this means some runs are different from CI.
163163
extraCargoArgs=("--no-default-features")
164164
cmds=()
165165
nextArgIsFilter=false

0 commit comments

Comments
 (0)