Skip to content

Commit 843d263

Browse files
committed
updating comments based on CI results
- also adjusted singleton test to use Servers level since that's what we are classifying them as
1 parent a488fe1 commit 843d263

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

godot-codegen/src/special_cases/special_cases.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,6 @@ pub fn classify_codegen_level(class_name: &str) -> Option<ClassCodegenLevel> {
10361036
| "RenderSceneData" | "RenderSceneDataExtension"
10371037
=> ClassCodegenLevel::Servers,
10381038
// Declared final (un-inheritable) in Rust, but those are still servers.
1039-
// NOTE: while these _types_ are available at Server level, the singletons themselves are actually not available until _even after_ Editor level.
10401039
| "AudioServer" | "CameraServer" | "NavigationServer2D" | "NavigationServer3D" | "RenderingServer" | "TranslationServer" | "XRServer" | "DisplayServer"
10411040
=> ClassCodegenLevel::Servers,
10421041

itest/rust/src/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ unsafe impl ExtensionLibrary for framework::IntegrationTests {
3333
// Make sure we can access early core singletons.
3434
object_tests::test_early_core_singletons();
3535
}
36-
InitLevel::Servers => {}
37-
InitLevel::Scene => {
36+
InitLevel::Servers => {
3837
// Make sure we can access server singletons by now.
39-
object_tests::test_general_singletons();
38+
object_tests::test_server_singletons();
4039
}
40+
InitLevel::Scene => {}
4141
InitLevel::Editor => {}
4242
}
4343
}

itest/rust/src/object_tests/init_level_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ pub fn test_early_core_singletons() {
6060
}
6161

6262
// Runs during scene init level to ensure we can access general singletons in the Scene init call for the extension as a whole.
63-
pub fn test_general_singletons() {
63+
pub fn test_server_singletons() {
6464
let mut rendering = godot::classes::RenderingServer::singleton();
6565
assert!(rendering.get_test_cube() != godot::builtin::Rid::Invalid);
6666
}

0 commit comments

Comments
 (0)