Upgrade commented-out tests to #[test(skip)]

Author: Bromeon

itest/rust/src/base_test.rs

@@ -7,12 +7,11 @@
 use crate::itest;
 use godot::prelude::*;
 
-/*
-#[itest]
+#[itest(skip)]
 fn base_test_is_weak() {
-    let obj = RefCounted::new();
+    // TODO check that Base is a weak pointer (doesn't keep the object alive)
+    // This might not be needed, as we have leak detection, but it could highlight regressions faster
 }
-*/
 
 #[itest]
 fn base_instance_id() {

itest/rust/src/node_test.rs

@@ -6,7 +6,7 @@
 
 use crate::itest;
 use godot::builtin::NodePath;
-use godot::engine::{node, Node, Node3D, NodeExt};
+use godot::engine::{global, node, Node, Node3D, NodeExt, PackedScene, SceneTree};
 use godot::obj::Share;
 
 #[itest]
@@ -54,8 +54,7 @@ fn node_get_node_fail() {
     child.free();
 }
 
-/*
-#[itest]
+#[itest(skip)]
 fn node_scene_tree() {
     let mut child = Node::new_alloc();
     child.set_name("kid".into());
@@ -82,4 +81,3 @@ fn node_scene_tree() {
     parent.free();
     child.free();
 }
-*/

itest/rust/src/packed_array_test.rs

@@ -41,14 +41,16 @@ fn packed_array_to_vec() {
     assert_eq!(array.to_vec(), vec![1, 2]);
 }
 
-// #[itest]
-// fn packed_array_into_iterator() {
-//     let array = Array::from(&[1, 2]);
-//     let mut iter = array.into_iter();
-//     assert_eq!(iter.next(), Some(1));
-//     assert_eq!(iter.next(), Some(2));
-//     assert_eq!(iter.next(), None);
-// }
+/*
+#[itest(skip)]
+fn packed_array_into_iterator() {
+    let array = PackedByteArray::from(&[1, 2]);
+    let mut iter = array.into_iter();
+    assert_eq!(iter.next(), Some(1));
+    assert_eq!(iter.next(), Some(2));
+    assert_eq!(iter.next(), None);
+}
+*/
 
 #[itest]
 fn packed_array_eq() {

itest/rust/src/string_test.rs

@@ -74,17 +74,17 @@ fn string_name_default_construct() {
     assert_eq!(back, GodotString::new());
 }
 
-#[itest]
+#[itest(skip)]
 fn string_name_eq_hash() {
     // TODO
 }
 
-#[itest]
+#[itest(skip)]
 fn string_name_ord() {
     // TODO
 }
 
-#[itest]
+#[itest(skip)]
 fn string_name_clone() {
     // TODO
 }

itest/rust/src/variant_test.rs

@@ -245,6 +245,28 @@ fn variant_sys_conversion() {
     assert_eq!(v2, v);
 }
 
+#[itest(skip)]
+fn variant_sys_conversion2() {
+    use godot::sys;
+
+    // FIXME alignment, maybe use alloc()
+    let mut buffer = [0u8; 50];
+
+    let v = Variant::from(7);
+    unsafe { v.write_sys(buffer.as_mut_ptr() as sys::GDExtensionTypePtr) };
+
+    let v2 = unsafe {
+        Variant::from_sys_init(|ptr| {
+            std::ptr::copy(
+                buffer.as_ptr(),
+                ptr as *mut u8,
+                std::mem::size_of_val(&*ptr),
+            )
+        })
+    };
+    assert_eq!(v2, v);
+}
+
 #[itest]
 fn variant_null_object_is_nil() {
     use godot::sys;
@@ -265,23 +287,6 @@ fn variant_null_object_is_nil() {
     node.free();
 }
 
-#[itest]
-fn variant_sys_conversion2() {
-    /*
-    let buffer = [0u8; 50];
-
-    let v = Variant::from(7);
-    unsafe { v.write_sys(buffer.as_mut_ptr()) };
-
-    let v2 = unsafe {
-        Variant::from_sys_init(|ptr| {
-            std::ptr::copy(buffer.as_ptr(), ptr as *mut u8, std::mem::size_of_val(*ptr))
-        })
-    };
-    assert_eq!(v2, v);
-    */
-}
-
 #[itest]
 fn variant_conversion_fails() {
     assert_eq!(