Remove static lifetime in StringName::from(&CStr)

Author: beicause

godot-core/src/builtin/string/string_name.rs

@@ -35,9 +35,8 @@ use crate::{impl_shared_string_api, meta};
 ///
 /// # Performance
 ///
-/// The fastest way to create string names is by using null-terminated C-string literals such as `c"MyClass"`. These have `'static` lifetime and
-/// can be used directly by Godot, without allocation or conversion. The encoding is limited to Latin-1, however. See the corresponding
-/// [`From<&'static CStr>` impl](#impl-From<%26CStr>-for-StringName).
+/// The fastest way to create string names is by using null-terminated C-string literals such as `c"MyClass"`. These can be used directly by Godot without conversion. The encoding is limited to Latin-1, however. See the corresponding
+/// [`From<&CStr>` impl](#impl-From<%26CStr>-for-StringName).
 ///
 /// # All string types
 ///
@@ -249,11 +248,6 @@ impl StringName {
     pub fn as_inner(&self) -> inner::InnerStringName<'_> {
         inner::InnerStringName::from_outer(self)
     }
-
-    /// Increment ref-count. This may leak memory if used wrongly.
-    fn inc_ref(&self) {
-        std::mem::forget(self.clone());
-    }
 }
 
 // SAFETY:
@@ -384,8 +378,8 @@ impl From<NodePath> for StringName {
     }
 }
 
-impl From<&'static std::ffi::CStr> for StringName {
-    /// Creates a `StringName` from a static ASCII/Latin-1 `c"string"`.
+impl From<&std::ffi::CStr> for StringName {
+    /// Creates a `StringName` from a ASCII/Latin-1 `c"string"`.
     ///
     /// This avoids unnecessary copies and allocations and directly uses the backing buffer. Useful for literals.
     ///
@@ -399,23 +393,17 @@ impl From<&'static std::ffi::CStr> for StringName {
     /// // '±' is a Latin-1 character with codepoint 0xB1. Note that this is not UTF-8, where it would need two bytes.
     /// let sname = StringName::from(c"\xb1 Latin-1 string");
     /// ```
-    fn from(c_str: &'static std::ffi::CStr) -> Self {
+    fn from(c_str: &std::ffi::CStr) -> Self {
         // SAFETY: c_str is nul-terminated and remains valid for entire program duration.
-        let result = unsafe {
+        unsafe {
             Self::new_with_string_uninit(|ptr| {
                 sys::interface_fn!(string_name_new_with_latin1_chars)(
                     ptr,
                     c_str.as_ptr(),
-                    sys::conv::SYS_TRUE, // p_is_static
+                    sys::conv::SYS_FALSE, // p_is_static
                 )
             })
-        };
-
-        // StringName expects that the destructor is not invoked on static instances (or only at global exit; see SNAME(..) macro in Godot).
-        // According to testing with godot4 --verbose, there is no mention of "Orphan StringName" at shutdown when incrementing the ref-count,
-        // so this should not leak memory.
-        result.inc_ref();
-        result
+        }
     }
 }