Add godot-nightly (bindgen) jobs to CI

Also update artifacts repo + branch version to "4.0.1"

Author: Bromeon

.github/workflows/full-ci.yml

@@ -181,6 +181,14 @@ jobs:
             rust-extra-args: --features double-precision
             with-llvm: true
 
+          - name: macos-bindgen
+            artifact-name: macos
+            os: macos-12
+            rust-toolchain: stable
+            godot-binary: godot.macos.editor.dev.x86_64
+            with-llvm: true
+            rust-extra-args: --features godot/custom-godot
+
           - name: windows
             os: windows-latest
             rust-toolchain: stable-x86_64-pc-windows-msvc
@@ -192,6 +200,13 @@ jobs:
             godot-binary: godot.windows.editor.dev.double.x86_64.exe
             rust-extra-args: --features double-precision
 
+          - name: windows-bindgen
+            artifact-name: windows
+            os: windows-latest
+            rust-toolchain: stable-x86_64-pc-windows-msvc
+            godot-binary: godot.windows.editor.dev.x86_64.exe
+            rust-extra-args: --features godot/custom-godot
+
           # Don't use latest Ubuntu (22.04) as it breaks lots of ecosystem compatibility.
           # If ever moving to ubuntu-latest, need to manually install libtinfo5 for LLVM.
           - name: linux
@@ -210,8 +225,7 @@ jobs:
             os: ubuntu-20.04
             rust-toolchain: stable
             godot-binary: godot.linuxbsd.editor.dev.x86_64
-            rust-extra-args: --features custom-godot
-
+            rust-extra-args: --features godot/custom-godot
 
           # Special Godot binaries compiled with AddressSanitizer/LeakSanitizer to detect UB/leaks.
           # Additionally, the Godot source is patched to make dlclose() a no-op, as unloading dynamic libraries loses stacktrace and

godot-bindings/Cargo.toml

@@ -7,14 +7,18 @@ license = "MPL-2.0"
 keywords = ["gamedev", "godot", "engine", "ffi", "sys"]
 categories = ["game-engines", "graphics"]
 
+# Since features are additive and we want the user to user prebuilt by default, we need to have `prebuilt-godot` as the
+# default feature. However, it's not possible to _disable_ the prebuilt dependency when specifying `godot-custom` (without
+# requiring no-default-features), so we unfortunately still need to depend on prebuilt and just ignore it.
+# The artifact generator explicitly excludes that though (to avoid a quasi-circular dependency back to its repo).
 [features]
 default = ["prebuilt-godot"]
 prebuilt-godot = ["dep:godot4-prebuilt"]
 custom-godot = ["dep:bindgen", "dep:regex", "dep:which"]
 custom-godot-extheader = []
 
 [dependencies]
-godot4-prebuilt = { optional = true, git = "https://github.com/godot-rust/godot4-artifacts", branch = "4.0" }
+godot4-prebuilt = { optional = true, git = "https://github.com/godot-rust/godot4-prebuilt", branch = "4.0.1" }
 
 # Version >= 1.5.5 for security: https://blog.rust-lang.org/2022/03/08/cve-2022-24713.html
 # 'unicode-gencat' needed for \d, see: https://docs.rs/regex/1.5.5/regex/#unicode-features

godot-bindings/src/lib.rs

@@ -10,11 +10,12 @@ use std::path::Path;
 
 pub use watch::StopWatch;
 
-#[cfg(all(feature = "custom-godot", feature = "prebuilt-godot"))]
-compile_error!("Exactly one of `custom-godot` or `prebuilt-godot` must be specified (both given).");
+// Note: we cannot prevent both `custom-godot` and `prebuilt-godot` from being specified; see Cargo.toml for more information.
 
 #[cfg(not(any(feature = "custom-godot", feature = "prebuilt-godot")))]
-compile_error!("Exactly one of `custom-godot` or `prebuilt-godot` must be specified (none given).");
+compile_error!(
+    "At least one of `custom-godot` or `prebuilt-godot` must be specified (none given)."
+);
 
 // ----------------------------------------------------------------------------------------------------------------------------------------------
 // Regenerate all files
@@ -50,7 +51,7 @@ pub use custom::*;
 // ----------------------------------------------------------------------------------------------------------------------------------------------
 // Reuse existing files
 
-#[cfg(feature = "prebuilt-godot")]
+#[cfg(not(feature = "custom-godot"))]
 #[path = ""]
 mod prebuilt {
     use super::*;
@@ -67,7 +68,7 @@ mod prebuilt {
     }
 }
 
-#[cfg(feature = "prebuilt-godot")]
+#[cfg(not(feature = "custom-godot"))]
 pub use prebuilt::*;
 
 // ----------------------------------------------------------------------------------------------------------------------------------------------

godot-core/build.rs

@@ -7,7 +7,10 @@
 use std::path::Path;
 
 fn main() {
-    let gen_path = Path::new(concat!(env!("CARGO_MANIFEST_DIR"), "/src/gen/"));
+    let gen_path = Path::new(concat!(
+        env!("CARGO_MANIFEST_DIR"),
+        "/../target/godot-gen/core"
+    ));
 
     if gen_path.exists() {
         std::fs::remove_dir_all(gen_path).unwrap_or_else(|e| panic!("failed to delete dir: {e}"));

godot-core/src/lib.rs

@@ -24,6 +24,7 @@ pub mod engine;
 #[allow(unused_imports, dead_code, non_upper_case_globals, non_snake_case, clippy::too_many_arguments, clippy::let_and_return, clippy::new_ret_no_self)]
 #[allow(clippy::upper_case_acronyms)] // TODO remove this line once we transform names
 #[allow(clippy::wrong_self_convention)] // TODO remove once to_string is const
+#[path = "../../target/godot-gen/core/mod.rs"]
 mod gen;
 
 #[doc(hidden)]

godot-ffi/build.rs

@@ -11,7 +11,10 @@ use std::path::Path;
 fn main() {
     let mut watch = godot_bindings::StopWatch::start();
 
-    let gen_path = Path::new(concat!(env!("CARGO_MANIFEST_DIR"), "/src/gen/"));
+    let gen_path = Path::new(concat!(
+        env!("CARGO_MANIFEST_DIR"),
+        "/../target/godot-gen/ffi"
+    ));
     let header_rs_path = gen_path.join("gdextension_interface.rs");
 
     godot_bindings::clear_dir(gen_path, &mut watch);

godot-ffi/src/lib.rs

@@ -17,6 +17,7 @@
     deref_nullptr,
     clippy::redundant_static_lifetimes
 )]
+#[path = "../../target/godot-gen/ffi/mod.rs"]
 pub(crate) mod gen;
 
 mod godot_ffi;