Fixing build errors, appeasing clippy.

Author: halzy

bindings_generator/src/documentation.rs

@@ -18,7 +18,7 @@ pub fn official_doc_url(class: &GodotClass) -> String {
 }
 
 pub fn generate_class_documentation(api: &Api, class: &GodotClass) -> TokenStream {
-    let has_parent = class.base_class != "";
+    let has_parent = !class.base_class.is_empty();
     let singleton_str = if class.singleton { "singleton " } else { "" };
     let ownership_type = if class.is_refcounted() {
         "reference counted"
@@ -81,7 +81,7 @@ if it is a `Node`."#,
         "".into()
     };
 
-    let base_class_docs = if class.base_class != "" {
+    let base_class_docs = if !class.base_class.is_empty() {
         let mut docs = vec![];
         write!(
             &mut docs,
@@ -138,7 +138,7 @@ fn list_base_classes(output: &mut impl Write, api: &Api, parent_name: &str) -> G
 
         writeln!(output, " - {}", class_link)?;
 
-        if parent.base_class != "" {
+        if !parent.base_class.is_empty() {
             list_base_classes(output, api, &parent.base_class)?;
         }
     }

gdnative-core/src/core_types/geom/plane.rs

@@ -128,7 +128,8 @@ impl Plane {
 
         let dist = (self.normal.dot(begin) - self.d) / den;
 
-        if dist < -std::f32::EPSILON || dist > (1.0 + std::f32::EPSILON) {
+        // check that dist is not in -EPSILON..(EPSILON+1)
+        if !(-std::f32::EPSILON..=(std::f32::EPSILON + 1.0)).contains(&dist) {
             return None;
         }
 

gdnative-core/src/core_types/variant.rs

@@ -1816,7 +1816,7 @@ godot_test!(
     test_variant_option {
         use std::marker::PhantomData;
 
-        let variant = Some(42 as i64).to_variant();
+        let variant = Some(42_i64).to_variant();
         assert_eq!(Some(42), variant.try_to_i64());
 
         let variant = Option::<bool>::None.to_variant();
@@ -1841,11 +1841,11 @@ godot_test!(
     }
 
     test_variant_result {
-        let variant = Result::<i64, ()>::Ok(42 as i64).to_variant();
+        let variant = Result::<i64, ()>::Ok(42_i64).to_variant();
         let dict = variant.try_to_dictionary().expect("should be dic");
         assert_eq!(Some(42), dict.get("Ok").try_to_i64());
 
-        let variant = Result::<(), i64>::Err(54 as i64).to_variant();
+        let variant = Result::<(), i64>::Err(54_i64).to_variant();
         let dict = variant.try_to_dictionary().expect("should be dic");
         assert_eq!(Some(54), dict.get("Err").try_to_i64());