Minor dependency + clippy + check.sh + doc adjustments

Author: Bromeon

bindings-generator/Cargo.toml

@@ -21,7 +21,7 @@ memchr = "2"
 miniserde = "0.1.10"
 proc-macro2 = "1"
 quote = "1"
-regex = "1.5.5" # for security: https://blog.rust-lang.org/2022/03/08/cve-2022-24713.html
+regex = { version = "1.5.5", default-features = false } # for security: https://blog.rust-lang.org/2022/03/08/cve-2022-24713.html
 roxmltree = "0.14"
 syn = { version = "1", features = ["full", "extra-traits", "visit"] }
 unindent = "0.1.5"

check.sh

@@ -22,6 +22,7 @@ for arg in "${args[@]}"; do
         echo "    test          run unit tests (no Godot)"
         echo "    itest         run integration tests (Godot)"
         echo "    doc           generate docs for 'gdnative' crate"
+        echo "    dok           generate docs and open in browser"
         echo ""
         echo "Examples:"
         echo "    check.sh fmt clippy"
@@ -82,6 +83,9 @@ for arg in "${args[@]}"; do
     doc)
         cmds+=("cargo doc --lib -p gdnative --no-deps --features $features")
         ;;
+    dok)
+        cmds+=("cargo doc --lib -p gdnative --no-deps --features $features --open")
+        ;;
     *)
         echo "Unrecognized command '$arg'"
         exit 2

gdnative-core/src/core_types/pool_array.rs

@@ -133,6 +133,7 @@ impl<T: PoolElement> PoolArray<T> {
     ///
     /// If the resulting length would not fit in `i32`.
     #[inline]
+    #[allow(clippy::iter_with_drain)] // "`drain(..)` used on a `Vec`"; suggests `into_iter()` but we don't have the vec by value
     pub fn append_vec(&mut self, src: &mut Vec<T>) {
         let start = self.len() as usize;
         let new_len = start + src.len();
@@ -266,7 +267,7 @@ impl<T: PoolElement> PoolArray<T> {
 impl<T: PoolElement + Copy> PoolArray<T> {
     /// Creates a new `PoolArray` by copying from `src`.
     ///
-    /// Equivalent to
+    /// Equivalent to a new object created with [`new()`][Self::new], followed by a subsequent [`append_slice()`][Self::append_slice].
     ///
     /// # Panics
     ///

test/Cargo.toml

@@ -24,6 +24,6 @@ serde = "1"
 serde_json = "1"
 bincode = "1"
 serde_yaml = "0.8.23"
-rmp-serde = "0.15"
+rmp-serde = "1"
 futures = "0.3"
 once_cell = "1"