6 add share completed share failed share cancelled signals (#7)

* Added completed, canceled, & failed signals
* Added signal info to README doc

Author: cengiz-pz

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -75,9 +75,8 @@ body:
     options:
       - "5.0"
       - "5.1"
-      - "5.2"
       - Other
-    default: 2
+    default: 1
   validations:
     required: true
 - type: dropdown

.github/ISSUE_TEMPLATE/feature_request.yaml

@@ -72,9 +72,8 @@ body:
     options:
       - "5.0"
       - "5.1"
-      - "5.2"
       - Other
-    default: 2
+    default: 1
   validations:
     required: true
 - type: dropdown

.gitignore

@@ -6,6 +6,7 @@ demo/addons
 demo/android
 demo/ios
 build/
+release/
 export.cfg
 
 # General
@@ -15,6 +16,7 @@ export.cfg
 # Android
 .gradle/
 *.jar
+!android/gradle/wrapper/gradle-wrapper.jar
 *.aar
 local.properties
 
@@ -25,6 +27,7 @@ local.properties
 *.d
 *.o
 *.dblite
+xcuserdata/
 Pods/
 ios/godot/
 

README.md

@@ -22,6 +22,7 @@ Share Plugin allows sharing of text and images on Android and iOS platforms.
 ## <img src="addon/icon.png" width="20"> Table of Contents
 - [Installation](#installation)
 - [Usage](#usage)
+- [Signals](#signals)
 - [Platform-Specific Notes](#platform-specific-notes)
 - [Links](#links)
 - [All Plugins](#all-plugins)
@@ -65,6 +66,18 @@ Add a `Share` node to your scene and follow the following steps:
 
 ---
 
+<a name="signals"></a>
+
+## <img src="addon/icon.png" width="20"> Signals
+
+- `share_completed`: Emitted when shared item is sent on iOS. On Android, emitted when a share target is selected on the chooser screen.
+- `share_canceled`: Emitted when user does not send shared item on iOS. On Android, emitted when user returns to app without making a selection on chooser screen within threshold milliseconds (default threshold is 5000ms).
+- `share_failed`: Emitted when a failure that prevents sharing occurs.
+
+*Note: On Android, `share_completed` signal does not mean that the user actually sent the shared item.*
+
+---
+
 <a name="platform-specific-notes"></a>
 
 ## <img src="addon/icon.png" width="20"> Platform-Specific Notes

addon/Share.gd

@@ -7,9 +7,17 @@ class_name Share extends Node
 
 const PLUGIN_SINGLETON_NAME: String = "@pluginName@"
 
+signal share_completed(activity_type: String)
+signal share_failed(error_message: String)
+signal share_canceled()
+
 const MIME_TYPE_TEXT: String = "text/plain"
 const MIME_TYPE_IMAGE: String = "image/*"
 
+const SIGNAL_NAME_SHARE_COMPLETED: String = "share_completed";
+const SIGNAL_NAME_SHARE_FAILED: String = "share_failed";
+const SIGNAL_NAME_SHARE_CANCELED: String = "share_canceled";
+
 @onready var _temp_image_path: String = OS.get_user_data_dir() + "/tmp_share_img_path.png"
 
 var _plugin_singleton: Object
@@ -28,10 +36,17 @@ func _update_plugin() -> void:
 	if _plugin_singleton == null:
 		if Engine.has_singleton(PLUGIN_SINGLETON_NAME):
 			_plugin_singleton = Engine.get_singleton(PLUGIN_SINGLETON_NAME)
+			_connect_signals()
 		elif not OS.has_feature("editor_hint"):
 			log_error("%s singleton not found!" % PLUGIN_SINGLETON_NAME)
 
 
+func _connect_signals() -> void:
+	_plugin_singleton.connect(SIGNAL_NAME_SHARE_COMPLETED, _on_share_completed)
+	_plugin_singleton.connect(SIGNAL_NAME_SHARE_FAILED, _on_share_failed)
+	_plugin_singleton.connect(SIGNAL_NAME_SHARE_CANCELED, _on_share_canceled)
+
+
 func share_text(a_title: String, a_subject: String, a_content: String) -> void:
 	if _plugin_singleton != null:
 		_plugin_singleton.share(
@@ -79,6 +94,18 @@ func share_file(a_path: String, a_mime_type: String, a_title: String, a_subject:
 		log_error("%s plugin not initialized" % PLUGIN_SINGLETON_NAME)
 
 
+func _on_share_completed(a_activity_type: String) -> void:
+	emit_signal(SIGNAL_NAME_SHARE_COMPLETED, a_activity_type)
+
+
+func _on_share_failed(a_error_message: String) -> void:
+	emit_signal(SIGNAL_NAME_SHARE_FAILED, a_error_message)
+
+
+func _on_share_canceled() -> void:
+	emit_signal(SIGNAL_NAME_SHARE_CANCELED)
+
+
 static func log_error(a_description: String) -> void:
 	push_error(a_description)
 

addon/model/SharedData.gd

@@ -2,14 +2,14 @@
 # © 2024-present https://github.com/cengiz-pz
 #
 
-class_name SharedData
-extends RefCounted
+class_name SharedData extends RefCounted
 
 const DATA_KEY_TITLE = "title"
 const DATA_KEY_SUBJECT = "subject"
 const DATA_KEY_CONTENT = "content"
 const DATA_KEY_FILE_PATH = "file_path"
 const DATA_KEY_MIME_TYPE = "mime_type"
+const DATA_KEY_CUSTOM_THRESHOLD_MS = "custom_threshold"
 
 var _data: Dictionary
 
@@ -43,5 +43,10 @@ func set_mime_type(a_mime_type: String) -> SharedData:
 	return self
 
 
+func set_custom_threshold(a_threshold_ms: int) -> SharedData:
+	_data[DATA_KEY_CUSTOM_THRESHOLD_MS] = a_threshold_ms
+	return self
+
+
 func get_raw_data() -> Dictionary:
 	return _data

android/config.gradle.kts

@@ -34,6 +34,7 @@ extra.apply {
 	set("templateDirectory", "../../addon")
 
 	// iOS
+	set("iosPlatformVersion", iosProperties.getProperty("platform_version"))
 	set("iosFrameworks", iosProperties.getProperty("frameworks"))
 	set("iosEmbeddedFrameworks", iosProperties.getProperty("embedded_frameworks"))
 	set("iosLinkerFlags", iosProperties.getProperty("flags"))

android/gradle/wrapper/gradle-wrapper.jar

@@ -2,9 +2,11 @@
 // © 2024-present https://github.com/cengiz-pz
 //
 
-import org.apache.tools.ant.filters.ReplaceTokens
 import com.android.build.gradle.internal.api.LibraryVariantOutputImpl
 
+import org.apache.tools.ant.filters.ReplaceTokens
+
+
 plugins {
 	alias(libs.plugins.android.library)
 	alias(libs.plugins.kotlin.android)
@@ -42,7 +44,7 @@ android {
 
 	buildToolsVersion = libs.versions.buildTools.get()
 
-	// ✅ Force AAR filenames to match original case and format
+	// Force AAR filenames to match original case and format
 	libraryVariants.all {
 		outputs.all {
 			val outputImpl = this as LibraryVariantOutputImpl
@@ -102,6 +104,7 @@ tasks {
 			"pluginVersion" to (project.extra["pluginVersion"] as String),
 			"pluginPackage" to (project.extra["pluginPackageName"] as String),
 			"androidDependencies" to androidDependencies.joinToString(", ") { "\"$it\"" },
+			"iosPlatformVersion" to (project.extra["iosPlatformVersion"] as String),
 			"iosFrameworks" to (project.extra["iosFrameworks"] as String)
 				.split(",")
 				.map { it.trim() }
@@ -121,9 +124,27 @@ tasks {
 	}
 
 	register<de.undercouch.gradle.tasks.download.Download>("downloadGodotAar") {
+		val destFile = file("${project.rootDir}/libs/${project.extra["godotAarFile"]}")
+
 		src(project.extra["godotAarUrl"] as String)
-		dest(file("${project.rootDir}/libs/${project.extra["godotAarFile"]}"))
+		dest(destFile)
 		overwrite(false)
+
+		onlyIf {
+			val exists = destFile.exists() && destFile.length() > 0
+			if (exists) {
+				println("[DEBUG] File already exists and is non-empty: ${destFile.absolutePath} (${destFile.length()} bytes)")
+				println("[DEBUG] Skipping download.")
+			} else {
+				if (destFile.exists()) {
+					println("[DEBUG] File exists but is empty: ${destFile.absolutePath}")
+				} else {
+					println("[DEBUG] File not found: ${destFile.absolutePath}")
+				}
+				println("[DEBUG] Proceeding with download...")
+			}
+			!exists // run task only if file does NOT exist or is empty
+		}
 	}
 
 	named("preBuild") {