Skip to content

Commit 751b302

Browse files
committed
Disable signing of Windows/UWP export templates
This causes issues for people who want to embed the PCK, change PE data with rcedit or sign the executable themselves. See godotengine/godot#32310 and godotengine/godot#33466.
1 parent 3319757 commit 751b302

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

build-release.sh

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,6 @@ if [ "${build_classical}" == "1" ]; then
123123

124124
strip ${templatesdir}/windows*.exe
125125

126-
sign ${templatesdir}/windows_64_release.exe
127-
sign ${templatesdir}/windows_64_debug.exe
128-
sign ${templatesdir}/windows_32_release.exe
129-
sign ${templatesdir}/windows_32_debug.exe
130-
131126
## OSX (Classical) ##
132127

133128
# Editor
@@ -210,24 +205,18 @@ if [ "${build_classical}" == "1" ]; then
210205

211206
cp out/uwp/arm/godot.uwp.opt.32.arm.exe uwp_template_ARM/godot.uwp.exe
212207
cp out/uwp/arm/godot.uwp.opt.debug.32.arm.exe uwp_template_ARM_debug/godot.uwp.exe
213-
sign uwp_template_ARM/godot.uwp.exe
214-
sign uwp_template_ARM_debug/godot.uwp.exe
215208
cd uwp_template_ARM && zip -q -9 -r "${templatesdir}/uwp_arm_release.zip" * && cd ..
216209
cd uwp_template_ARM_debug && zip -q -9 -r "${templatesdir}/uwp_arm_debug.zip" * && cd ..
217210
rm -rf uwp_template_ARM*
218211

219212
cp out/uwp/x86/godot.uwp.opt.32.x86.exe uwp_template_Win32/godot.uwp.exe
220213
cp out/uwp/x86/godot.uwp.opt.debug.32.x86.exe uwp_template_Win32_debug/godot.uwp.exe
221-
sign uwp_template_Win32/godot.uwp.exe
222-
sign uwp_template_Win32_debug/godot.uwp.exe
223214
cd uwp_template_Win32 && zip -q -9 -r "${templatesdir}/uwp_x86_release.zip" * && cd ..
224215
cd uwp_template_Win32_debug && zip -q -9 -r "${templatesdir}/uwp_x86_debug.zip" * && cd ..
225216
rm -rf uwp_template_Win32*
226217

227218
cp out/uwp/x64/godot.uwp.opt.64.x64.exe uwp_template_x64/godot.uwp.exe
228219
cp out/uwp/x64/godot.uwp.opt.debug.64.x64.exe uwp_template_x64_debug/godot.uwp.exe
229-
sign uwp_template_x64/godot.uwp.exe
230-
sign uwp_template_x64_debug/godot.uwp.exe
231220
cd uwp_template_x64 && zip -q -9 -r "${templatesdir}/uwp_x64_release.zip" * && cd ..
232221
cd uwp_template_x64_debug && zip -q -9 -r "${templatesdir}/uwp_x64_debug.zip" * && cd ..
233222
rm -rf uwp_template_x64*
@@ -297,11 +286,6 @@ if [ "${build_mono}" == "1" ]; then
297286

298287
strip ${templatesdir_mono}/windows*.exe
299288

300-
sign ${templatesdir_mono}/windows_64_debug.exe
301-
sign ${templatesdir_mono}/windows_64_release.exe
302-
sign ${templatesdir_mono}/windows_32_debug.exe
303-
sign ${templatesdir_mono}/windows_32_release.exe
304-
305289
mkdir -p ${templatesdir_mono}/bcl
306290
cp -r out/windows/x64/tools-mono/GodotSharp/Mono/lib/mono/4.5/ ${templatesdir_mono}/bcl/net_4_x_win
307291

0 commit comments

Comments
 (0)