Skip to content

Commit 7d7c728

Browse files
committed
Fixes following issues:
1. Google play billing method(OnGodotGooglePlayBilling_sku_details_query_error) signature in GooglePlayBilling class doesn't match with Godot's android library exposed method Check: https://github.com/godotengine/godot-google-play-billing/blob/master/godot-google-play-billing/src/main/java/org/godotengine/godot/plugin/googleplaybilling/GodotGooglePlayBilling.java Line: 236. 2. "OnConnectError" method signature mismatch
1 parent f08916c commit 7d7c728

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

mono/android_iap/GodotGooglePlayBilling/GooglePlayBilling.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class GooglePlayBilling : Node
1515
[Signal] public delegate void Disconnected();
1616
[Signal] public delegate void ConnectError(int code, string message);
1717
[Signal] public delegate void SkuDetailsQueryCompleted(Array skuDetails);
18-
[Signal] public delegate void SkuDetailsQueryError(int code, string message);
18+
[Signal] public delegate void SkuDetailsQueryError(int code, string message, string[] querySkuDetails);
1919
[Signal] public delegate void PurchasesUpdated(Array purchases);
2020
[Signal] public delegate void PurchaseError(int code, string message);
2121
[Signal] public delegate void PurchaseAcknowledged(string purchaseToken);
@@ -96,7 +96,7 @@ public PurchasesResult QueryPurchases(PurchaseType purchaseType)
9696

9797
private void OnGodotGooglePlayBilling_sku_details_query_completed(Array skuDetails) => EmitSignal(nameof(SkuDetailsQueryCompleted), skuDetails);
9898

99-
private void OnGodotGooglePlayBilling_sku_details_query_error(int code, string message) => EmitSignal(nameof(SkuDetailsQueryError), code, message);
99+
private void OnGodotGooglePlayBilling_sku_details_query_error(int code, string message, string[] querySkuDetails) => EmitSignal(nameof(SkuDetailsQueryError), code, message, querySkuDetails);
100100

101101
private void OnGodotGooglePlayBilling_purchases_updated(Array purchases) => EmitSignal(nameof(PurchasesUpdated), purchases);
102102

mono/android_iap/Main.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ private async void OnDisconnected()
9393
_payment.StartConnection();
9494
}
9595

96-
private void OnConnectError()
96+
private void OnConnectError(int code, string message)
9797
{
9898
ShowAlert("PurchaseManager connect error");
9999
}
@@ -136,7 +136,7 @@ private void OnSkuDetailsQueryCompleted(Godot.Collections.Array arrSkuDetails)
136136
}
137137
}
138138

139-
private void OnSkuDetailsQueryError(int code, string message)
139+
private void OnSkuDetailsQueryError(int code, string message, string[] querySkuDetails)
140140
{
141141
ShowAlert($"SKU details query error {code}: {message}");
142142
}

0 commit comments

Comments
 (0)