Skip to content

Commit edccce8

Browse files
authored
Fix normal map direction in 2D Lights and Shadows (#1123)
- Group Light2D nodes for easier dragging in the editor.
1 parent a87fded commit edccce8

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

2d/lights_and_shadows/godot_normal.png.import

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ roughness/mode=0
2727
roughness/src_normal=""
2828
process/fix_alpha_border=true
2929
process/premult_alpha=false
30-
process/normal_map_invert_y=false
30+
process/normal_map_invert_y=true
3131
process/hdr_as_srgb=false
3232
process/hdr_clamp_exposure=false
3333
process/size_limit=0

2d/lights_and_shadows/light_shadows.tscn

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ shadow_enabled = true
320320
shadow_filter = 1
321321
shadow_filter_smooth = 1.2
322322
texture = ExtResource("3")
323+
metadata/_edit_group_ = true
323324

324325
[node name="Blob" type="Sprite2D" parent="RedLight"]
325326
material = SubResource("2")
@@ -338,8 +339,9 @@ shadow_enabled = true
338339
shadow_filter = 1
339340
shadow_filter_smooth = 1.2
340341
texture = ExtResource("3")
342+
metadata/_edit_group_ = true
341343

342-
[node name="blob" type="Sprite2D" parent="GreenLight"]
344+
[node name="Blob" type="Sprite2D" parent="GreenLight"]
343345
material = SubResource("5")
344346
texture = ExtResource("4")
345347

@@ -356,8 +358,9 @@ shadow_enabled = true
356358
shadow_filter = 1
357359
shadow_filter_smooth = 1.2
358360
texture = ExtResource("3")
361+
metadata/_edit_group_ = true
359362

360-
[node name="blob" type="Sprite2D" parent="BlueLight"]
363+
[node name="Blob" type="Sprite2D" parent="BlueLight"]
361364
material = SubResource("6")
362365
texture = ExtResource("4")
363366

2d/lights_and_shadows/project.godot

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ config/description="Simple demo of 2D lights and shadows,
1515
using PointLight2D and LightOccluder2D."
1616
config/tags=PackedStringArray("2d", "demo", "official", "rendering")
1717
run/main_scene="res://light_shadows.tscn"
18-
config/features=PackedStringArray("4.2")
18+
config/features=PackedStringArray("4.3")
1919
config/icon="res://icon.webp"
2020

2121
[debug]
@@ -32,22 +32,22 @@ window/stretch/aspect="expand"
3232

3333
toggle_directional_light={
3434
"deadzone": 0.2,
35-
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":68,"physical_keycode":0,"key_label":0,"unicode":0,"echo":false,"script":null)
35+
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":68,"physical_keycode":0,"key_label":0,"unicode":0,"location":0,"echo":false,"script":null)
3636
]
3737
}
3838
toggle_point_lights={
3939
"deadzone": 0.2,
40-
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":80,"physical_keycode":0,"key_label":0,"unicode":0,"echo":false,"script":null)
40+
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":80,"physical_keycode":0,"key_label":0,"unicode":0,"location":0,"echo":false,"script":null)
4141
]
4242
}
4343
cycle_directional_light_shadows_quality={
4444
"deadzone": 0.2,
45-
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":83,"physical_keycode":0,"key_label":0,"unicode":0,"echo":false,"script":null)
45+
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":83,"physical_keycode":0,"key_label":0,"unicode":0,"location":0,"echo":false,"script":null)
4646
]
4747
}
4848
cycle_point_light_shadows_quality={
4949
"deadzone": 0.2,
50-
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":72,"physical_keycode":0,"key_label":0,"unicode":0,"echo":false,"script":null)
50+
"events": [Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","device":0,"window_id":0,"alt_pressed":false,"shift_pressed":false,"ctrl_pressed":false,"meta_pressed":false,"pressed":false,"keycode":72,"physical_keycode":0,"key_label":0,"unicode":0,"location":0,"echo":false,"script":null)
5151
]
5252
}
5353

0 commit comments

Comments
 (0)