-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update playing videos #10614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update playing videos #10614
Conversation
c61b397 to
00d0153
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing the documentation along with the PRs!
Here's what I see on a first read. This will be reviewed again when the engine PRs are merged
|
Thanks for the corrections. I've also reworded some of my changes for the better I hope. I've filed issues for FFmpeg and added links to them. |
082ff80 to
5520784
Compare
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
All Theora FFmpeg issues have been fixed in their master branch. These are the commits: FFmpeg/FFmpeg@22aa71d Thanks to the FFmpeg devs for their quick response. For now, their daily static builds should be used until these fixes are included in new release. I'll have to update the documentation, and I'm wondering if I should split this PR in two at the same time, since only one of the two PRs addressed here have been merged. |
Yes, can you please split out a PR that only documents the changes from godotengine/godot#101958 (and any other changes that got merged in 4.4, if they exist)? We'd like to get documentation for 4.4 changes merged before 4.4 releases as much as possible. |
3ee9e71 to
f2d2133
Compare
Add information about GOP size and caveats using FFmpeg.
|
Done. |
|
I edited the PR description to avoid mentioning godotengine/godot#102360. I'd suggest making a separate PR for the documentation changes for that PR |
OK. Forgot to remove it myself. |
|
I've removed the links to the issues in the warning block to avoid more information than strictly necessary. |
|
Thanks! |
Documents changes from godotengine/godot#101958.
-g:vto encode videos with a higher GOP size.Remove note about not being able to seek Theora files.Please, feel free to correct my writing.