Skip to content

Conversation

@berarma
Copy link
Contributor

@berarma berarma commented Feb 4, 2025

Documents changes from godotengine/godot#101958.

  • Add information about using -g:v to encode videos with a higher GOP size.
  • Add notes and warnings about problems when encoding Theora with FFmpeg.
  • Remove note about not being able to seek Theora files.

Please, feel free to correct my writing.

@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation waiting on pr merge PRs that can't be merged until an engine PR is merged first labels Feb 4, 2025
@berarma berarma force-pushed the update_playing_videos branch 2 times, most recently from c61b397 to 00d0153 Compare February 4, 2025 15:56
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing the documentation along with the PRs!

Here's what I see on a first read. This will be reviewed again when the engine PRs are merged

@berarma
Copy link
Contributor Author

berarma commented Feb 6, 2025

Thanks for the corrections. I've also reworded some of my changes for the better I hope.

I've filed issues for FFmpeg and added links to them.

@berarma berarma force-pushed the update_playing_videos branch 3 times, most recently from 082ff80 to 5520784 Compare February 11, 2025 18:11
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@berarma
Copy link
Contributor Author

berarma commented Feb 20, 2025

All Theora FFmpeg issues have been fixed in their master branch. These are the commits:

FFmpeg/FFmpeg@22aa71d
FFmpeg/FFmpeg@84d85e7
FFmpeg/FFmpeg@6e26f57

Thanks to the FFmpeg devs for their quick response.

For now, their daily static builds should be used until these fixes are included in new release.

I'll have to update the documentation, and I'm wondering if I should split this PR in two at the same time, since only one of the two PRs addressed here have been merged.

@tetrapod00
Copy link
Contributor

tetrapod00 commented Feb 25, 2025

I'll have to update the documentation, and I'm wondering if I should split this PR in two at the same time, since only one of the two PRs addressed here have been merged.

Yes, can you please split out a PR that only documents the changes from godotengine/godot#101958 (and any other changes that got merged in 4.4, if they exist)? We'd like to get documentation for 4.4 changes merged before 4.4 releases as much as possible.

@berarma berarma closed this Feb 26, 2025
@berarma berarma force-pushed the update_playing_videos branch from 3ee9e71 to f2d2133 Compare February 26, 2025 09:23
Add information about GOP size and caveats using FFmpeg.
@berarma berarma reopened this Feb 26, 2025
@berarma
Copy link
Contributor Author

berarma commented Feb 26, 2025

Done.

@berarma berarma marked this pull request as ready for review February 26, 2025 09:26
@tetrapod00 tetrapod00 removed the waiting on pr merge PRs that can't be merged until an engine PR is merged first label Feb 26, 2025
@tetrapod00
Copy link
Contributor

tetrapod00 commented Feb 26, 2025

I edited the PR description to avoid mentioning godotengine/godot#102360. I'd suggest making a separate PR for the documentation changes for that PR

@berarma
Copy link
Contributor Author

berarma commented Feb 26, 2025

I edited the PR description to avoid mentioning godotengine/godot#102360. I'd suggest making a separate PR for the documentation changes for that PR

OK. Forgot to remove it myself.

@berarma
Copy link
Contributor Author

berarma commented Feb 26, 2025

I've removed the links to the issues in the warning block to avoid more information than strictly necessary.

@skyace65 skyace65 added this to the 4.4 milestone Feb 27, 2025
@skyace65 skyace65 merged commit 8015e9f into godotengine:master Feb 27, 2025
2 checks passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants