Skip to content

Improve Creating your first script page #10663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skyace65 merged 1 commit into from
Feb 15, 2025
Merged

Improve Creating your first script page #10663

skyace65 merged 1 commit into from
Feb 15, 2025

Conversation

@tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Feb 10, 2025

  • Add godot.svg icon as an image, following what appears to be the intention of a comment on the page?
  • Update link to intro section based on comment. The last PR to touch this was Change link on the first script page #5677, which changed the comment, but only added a comment and not an actual anchor above the section in Getting Started/Introduction to Godot/What do I need to know to use Godot?. I think the intention here was to actually link to that section within the text of this page, but I'm not sure. CC @skyace65 if you still remember 😄
  • Update some styling to match current guidelines. I went easy on this and only updated things that obviously increase clarity or align with current guidelines. I didn't link to the class reference in a lot of places that I would have if this was a Manual page.

@tetrapod00
Improve Creating your first script page
45ba524 
- Add godot.svg icon according to comment.
- Update link to intro section based on comment.
- Update some styling to match current guidelines.
@tetrapod00 tetrapod00 added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation content:proofreading Issues and PRs related to proofreading the documentation labels Feb 10, 2025
skyace65
skyace65 approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was supposed to be a section link, not a comment

@skyace65 skyace65 merged commit 6d1d6f1 into godotengine:master Feb 15, 2025
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Feb 15, 2025

Thanks!

@tetrapod00 tetrapod00 deleted the improve-first-script branch February 15, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyace65 skyace65 skyace65 approved these changes

Assignees

No one assigned

Labels

area:getting started Issues and PRs related to the Getting Started section of the documentation content:proofreading Issues and PRs related to proofreading the documentation enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tetrapod00 @skyace65