Skip to content

Conversation

@rinevard
Copy link
Contributor

Update screenshots and descriptions in Asset Library documentation to match current interface.

Fixes #10661

@AThousandShips AThousandShips added enhancement area:community Issues and PRs related to the Community section of the documentation topic:assetlib labels Feb 10, 2025
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert the image to the .webp format.
you can read more about it in the Doc image guidelines.

@tetrapod00
Copy link
Contributor

Specifically, a good way to convert to webp if you already have lossless PNGs is to use squoosh with these settings to keep filesize down:
Screenshot 2025-02-10 094257
We mention that in the image guidelines but it can get lost in all the details

Additionally, can you scale down the images that are larger than 1920x1080, as described here? If you're able to retake the screenshots using a smaller window size that would work too. These screenshots don't really benefit from super-high resolutions (in a some cases, you can actually see visible pixelation from the asset library image assets that don't scale well to high resolution).

@rinevard
Copy link
Contributor Author

Thanks for your suggestions! I clicked the "commit suggestion" button at the bottom of AThousandShips's comment, but found tetrapod00's suggestion became outdated, so I manually changed the doc according to the suggestion. Now the images are converted to webp format and scaled properly. I also converted other PNG images in the asset_library/img folder to webp format.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good and the website screenshots look good.

For all the various Editor screenshots, if we're updating them to webp, we should also retake them in the latest version (4.4beta). Some of the UI has changed, for example, Rating is not a valid sort any more:
Screenshot 2025-02-10 180600
And the new Game workspace in the editor will require a change of the screenshots.

I would recommend either:

  • Retaking all relevant editor screenshots in 4.4 beta.
  • Undoing all the editor screenshots and leaving them as they were before this PR, if you would rather not expand the scope of the PR. Either is totally fine.

@rinevard
Copy link
Contributor Author

rinevard commented Feb 11, 2025

The text looks good and the website screenshots look good.

For all the various Editor screenshots, if we're updating them to webp, we should also retake them in the latest version (4.4beta). Some of the UI has changed, for example, Rating is not a valid sort any more: Screenshot 2025-02-10 180600 And the new Game workspace in the editor will require a change of the screenshots.

I would recommend either:

  • Retaking all relevant editor screenshots in 4.4 beta.
  • Undoing all the editor screenshots and leaving them as they were before this PR, if you would rather not expand the scope of the PR. Either is totally fine.

Thanks for your help. I've chosen to undo the editor screenshots changes (your second option) by:

  1. Removing the WebP versions
  2. Restoring the PNG versions from commit 058f0f6
  3. Committed the changes with message "Undo all the editor screenshots"

Let me know if anything else needs to be fixed.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is happy and so am I

@skyace65 skyace65 merged commit 78d2ddb into godotengine:master Feb 13, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:community Issues and PRs related to the Community section of the documentation enhancement topic:assetlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Asset Library documentation: outdated support levels and screenshots

4 participants