-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update screenshots and descriptions in Asset Library docs #10665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AThousandShips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert the image to the .webp format.
you can read more about it in the Doc image guidelines.
|
Specifically, a good way to convert to webp if you already have lossless PNGs is to use squoosh with these settings to keep filesize down: Additionally, can you scale down the images that are larger than 1920x1080, as described here? If you're able to retake the screenshots using a smaller window size that would work too. These screenshots don't really benefit from super-high resolutions (in a some cases, you can actually see visible pixelation from the asset library image assets that don't scale well to high resolution). |
Co-authored-by: A Thousand Ships <[email protected]>
|
Thanks for your suggestions! I clicked the "commit suggestion" button at the bottom of AThousandShips's comment, but found tetrapod00's suggestion became outdated, so I manually changed the doc according to the suggestion. Now the images are converted to webp format and scaled properly. I also converted other PNG images in the asset_library/img folder to webp format. |
tetrapod00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good and the website screenshots look good.
For all the various Editor screenshots, if we're updating them to webp, we should also retake them in the latest version (4.4beta). Some of the UI has changed, for example, Rating is not a valid sort any more:

And the new Game workspace in the editor will require a change of the screenshots.
I would recommend either:
- Retaking all relevant editor screenshots in 4.4 beta.
- Undoing all the editor screenshots and leaving them as they were before this PR, if you would rather not expand the scope of the PR. Either is totally fine.
Thanks for your help. I've chosen to undo the editor screenshots changes (your second option) by:
Let me know if anything else needs to be fixed. |
tetrapod00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is happy and so am I
|
Thanks! And congrats on your first merged PR! |


Update screenshots and descriptions in Asset Library documentation to match current interface.
Fixes #10661