-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update Tonemap docs in Environment and post-processing page #10716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, godotengine/godot#102820 is the corresponding engine PR for this
I don't think that using *Note:* like this in the manual makes that much sense stylistically. Other than that, I didn't suggest any changes to the text, since this is mostly a copy-paste job.
31a71f3 to
12e1e18
Compare
|
Agreed on all points @tetrapod00. I've pushed an update with all of your suggestions. (I favoured simply removing text in both cases where you suggested that as an option.) |
…e AgX and match 4.4.0 class reference. Co-authored-by: tetrapod <[email protected]>
12e1e18 to
ea849e5
Compare
|
I'm getting these errors on the checks: I tried re-running the checks, but that didn't resolve them. Let me know if this is something on my end that needs addressing... |
Not your fault, it's bad links on unrelated pages. Helpfully someone already made an issue for it: #10717. Looks like triggering the URL check on every PR means that we do get plenty of warning when something breaks 😄 |
|
Thanks! |
Update Tonemap docs in Environment and post-processing page to include AgX and match 4.4.0 class reference.
Historically, this page has been not much more than a copy-paste of the tonemap class reference text, so this PR updates to match the latest for 4.4.0
After 4.5 introduces the White parameter for AgX, it will be a good time to revisit this section and rewrite it as supplementary text to the class reference, rather than duplicate text.