Skip to content

Conversation

@allenwp
Copy link
Contributor

@allenwp allenwp commented Feb 25, 2025

Update Tonemap docs in Environment and post-processing page to include AgX and match 4.4.0 class reference.

Historically, this page has been not much more than a copy-paste of the tonemap class reference text, so this PR updates to match the latest for 4.4.0

After 4.5 introduces the White parameter for AgX, it will be a good time to revisit this section and rewrite it as supplementary text to the class reference, rather than duplicate text.

@tetrapod00 tetrapod00 added enhancement topic:rendering area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 25, 2025
@tetrapod00 tetrapod00 added this to the 4.4 milestone Feb 25, 2025
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, godotengine/godot#102820 is the corresponding engine PR for this

I don't think that using *Note:* like this in the manual makes that much sense stylistically. Other than that, I didn't suggest any changes to the text, since this is mostly a copy-paste job.

@allenwp allenwp force-pushed the update-tonemap-docs branch from 31a71f3 to 12e1e18 Compare February 26, 2025 16:30
@allenwp
Copy link
Contributor Author

allenwp commented Feb 26, 2025

Agreed on all points @tetrapod00. I've pushed an update with all of your suggestions. (I favoured simply removing text in both cases where you suggested that as an option.)

…e AgX and match 4.4.0 class reference.

Co-authored-by: tetrapod <[email protected]>
@allenwp allenwp force-pushed the update-tonemap-docs branch from 12e1e18 to ea849e5 Compare February 26, 2025 19:14
@allenwp
Copy link
Contributor Author

allenwp commented Feb 26, 2025

I'm getting these errors on the checks:

Run /home/runner/work/_actions/lycheeverse/lychee-action/v2/entrypoint.sh
   [WARN ] Cache is too old (age: 1d 0h 15m 17s, max age: 1d 0h 0m 0s). Discarding and recreating.
   [WARN ] Error creating request: InvalidBaseJoin("_static/")
   [WARN ] Error creating request: InvalidBaseJoin("res://someresource.res::1")
Error:  https://webd97.de/post/gitlab-pages-compression/ | Network error: error sending request for url (https://webd97.de/post/gitlab-pages-compression/) Maybe a certificate error?
## Errors per input

### Errors in tutorials/export/exporting_for_web.rst

Error: R] [https://webd97.de/post/gitlab-pages-compression/](https://webd97.de/post/gitlab-pages-compression/) | Network error: error sending request for url (https://webd97.de/post/gitlab-pages-compression/) Maybe a certificate error?

I tried re-running the checks, but that didn't resolve them. Let me know if this is something on my end that needs addressing...

@tetrapod00
Copy link
Contributor

I'm getting these errors on the checks

Not your fault, it's bad links on unrelated pages. Helpfully someone already made an issue for it: #10717.

Looks like triggering the URL check on every PR means that we do get plenty of warning when something breaks 😄

@skyace65 skyace65 merged commit 9c21ead into godotengine:master Feb 27, 2025
1 of 2 checks passed
@skyace65
Copy link
Contributor

Thanks!

@allenwp allenwp deleted the update-tonemap-docs branch March 2, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:rendering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants