-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix visual artifacts #10722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visual artifacts #10722
Conversation
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built this locally and everything looks good
|
@tetrapod00 do we have any preference one way or the other for using the |
|
There's no precedent for using
Cons:
I would make the call to remove |
tetrapod00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built it locally both with and without :nocontrols:. I would prefer these videos to have controls, even leaving aside the other reasons to avoid introducing :nocontrols:.
Co-authored-by: tetrapod <[email protected]>
Co-authored-by: tetrapod <[email protected]>
Co-authored-by: tetrapod <[email protected]>
Co-authored-by: tetrapod <[email protected]>
|
Applied tetrapods changes to remove |
|
Thanks! And congrats on your first merged PR! In the future though we'd recommend forking your master branch instead of making changes directly to it, that makes keeping it updated difficult. If you want to know more we have a git guide here: https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html |
This PR addresses issue
I’ve replaced the GIFs with WebM videos to eliminate visual artifacts.