String.format() wrong placeholder syntax #10741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: `var string = "I have {} cats.".format([3])`
To: `var string = "I have {0} cats.".format([3])`
tetrapod00
approved these changes
Mar 4, 2025
tetrapod00
added
bug
topic:gdscript
area:manual
Piralein
approved these changes
Mar 5, 2025
skyace65
approved these changes
Mar 5, 2025
Contributor
skyace65
left a comment
skyace65
left a comment
There was a problem hiding this comment.
Tested the old code, confirmed it doesn't work. Confirmed that the new code does work.
Contributor
|
Thanks! And congrats on your first merged PR! |
Contributor
Author
|
Thanks, appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From:
var string = "I have {} cats.".format([3])To:
var string = "I have {0} cats.".format([3])