Make HTTPRequest support a TimeSpan-based Timeout property instead of int for C# #4419
Replies: 2 comments
-
In the However, in the Changing this doesn't break compatibility with existing GDScript code, but it will break compatibility with existing GDNative plugins. This means the change can be considered for the future 3.x minor release, but not for a patch release. Also, if I'm not mistaken, Godot doesn't expose time properties as TimeSpans in C# anywhere yet, so I'd vouch for sticking to a float here. Edit: Pull request opened: godotengine/godot#60402 |
Beta Was this translation helpful? Give feedback.
-
I checked the master branch and saw that it was internally a |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently the
HTTPRequest
Timeout
property is anint
, which means a lack of precision. C# also has aTimeSpan
struct
which allows using whatever measurement the user decides. Internally, the timeout is adouble
so I don't see whyTimeout
is anint
in the first place.Beta Was this translation helpful? Give feedback.
All reactions