Improve usability of togglable icon buttons

[miv391]

Currently it is pretty much impossible to see the difference between most selected and non-selected icons. For example icon buttons used to select Path2D's edit modes:

In the first group the first button is selected, in the second group the second button is selected. It is faster and less error prone just to click the button instead of trying to see if the desired mode is already selected. This is of course very bad usability.

Proposal: Change selected icons so that the selection is clearly seen. Maybe a background color with high contrast to the current background color. Or bright yellow top border or full border. If the Godot devs want to keep the current look & feel regardless of the usability, then make this feature as an accessibility feature which can be enabled if wanted. In that case maximal visibility should be the goal, e.g. the yellow border could be good.

Yellow top border and yellow full border:

[Calinou]

In an earlier revision of the improved editor theme, I added a colored background to all pressed buttons (including flat buttons). I removed it for some reason – I don't remember why, but you may find the reason by reading the comments and collapsed sections in that PR.

If the Godot devs want to keep the current look & feel regardless of the usability, then make this feature as an accessibility feature which can be enabled if wanted.

This should not be an option, as good usability should be always enabled 🙂

[miv391]

I read that PR but couldn't find the exact reason why buttons were made flat. I think that the non-flat button looked pretty good and their usability is of course much better. If flat look is preferred, I also like my own "yellow top border" suggestion.

While reading that PR I noticed that two slightly different colors are used as a selection/highlight color. I wonder if that is done on purpose?

[Calinou]

While reading that PR I noticed that two slightly different colors are used as a selection/highlight color. I wonder if that is done on purpose?

I believe this was done on purpose because some people found the tab highlight too distracting. I didn't want to remove the tab highlight entirely though, as it does serve a purpose (making it easier to see which tab is currently selected).