Fix for an issue with Node Dock

[dnoftsger]

My partner and I were taking a look at this specific issue: godotengine/godot#84530

We believe we have an idea of how to fix this issue, and was looking for input or ideas from the developers on if we are on the right track.

We think that the issue lies in node_dock.cpp (https://github.com/godotengine/godot/blob/master/editor/node_dock.cpp), specifically with the destructor, as it currently does not undo many of the changes that occur when you create one, which would possibly be the cause for the issue linked above, in which you can still make changes to the groups and such on a node that no longer exists. We think that adding some lines to this destructor would help fix this issue, let us know what you think.

[kevmorg]

We have managed to get the windows for signals and groups to hide themselves at least on confirming the deletion of a node. We do this from the _delete_confirm function in scene_tree_dock.cpp on line 2310. Now we just need to locate where we can clear the actual signals and groups from a node to fix the issue.

[AThousandShips]

Please discuss development on the contributor chat, this is not for this kind of discussion but for discussing new features 🙂

[dnoftsger]

Apologies, thanks for showing us where to go

[AThousandShips]

No worries 🙂