Replies: 1 comment 1 reply
-
Sounds good. Feel free to open a PR with the change 🙂. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The Godot.NET.Sdk (for C# use) should define the property
UsingGodotNETSdk
in its SDK.props.Why
Defining this property allows shared build configuration (e.g. Directory.Build.targets or other imported msbuild files) to detect deterministically when they are operating within the scope of a project controlled by Godot.NET.Sdk. This enables shared build configuration that may span many different projects within a folder to have Godot.NET.Sdk-specific configuration that only applies to Godot projects.
Why named UsingGodotNETSdk
This naming scheme is common practice in Microsoft Dotnet SDKs. For example, the property
UsingMicrosoftNETSdk
is defined by the default SDK,UsingMicrosoftTraversalSdk
is defined by Microsoft.Build.Traversal,UsingMicrosoftNoTargetsSdk
by Microsoft.Build.NoTargets, and so on. The propertyUsingMicrosoftNETSdk
is even used in the implementation of Godot.NET.Sdk for conditional logic of the type predicted here.Note that these "Using*" properties are additive in the sense that more than one can be defined for a given project (as SDKs can effectively be built upon other SDKs, using them as components). So, it is normal and appropriate for both
UsingMicrosoftNETSdk
andUsingGodotNETSdk
to be simultaneously defined within the same project.Work Involved
This is a (literally) a one-line change in SDK.props.
Beta Was this translation helpful? Give feedback.
All reactions