Merge pull request #89595 from apples/89559-cpuparticles3d-angle-rotate_y-fix

akien-mga · akien-mga · commit 16eb8dbdc0aa · 2024-05-06T15:14:53.000+02:00
Fix `CPUParticles3D` using angle incorrectly when `ROTATE_Y` is set.
diff --git a/scene/3d/cpu_particles_3d.cpp b/scene/3d/cpu_particles_3d.cpp
@@ -1125,7 +1125,7 @@ void CPUParticles3D::_particles_process(double p_delta) {
 			//turn particle by rotation in Y
 			if (particle_flags[PARTICLE_FLAG_ROTATE_Y]) {
 				Basis rot_y(Vector3(0, 1, 0), p.custom[0]);
-				p.transform.basis = p.transform.basis * rot_y;
+				p.transform.basis = rot_y;
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1125,7 +1125,7 @@ void CPUParticles3D::_particles_process(double p_delta) {`
`1125`	`1125`	`//turn particle by rotation in Y`
`1126`	`1126`	`if (particle_flags[PARTICLE_FLAG_ROTATE_Y]) {`
`1127`	`1127`	`Basis rot_y(Vector3(0, 1, 0), p.custom[0]);`
`1128`		`- p.transform.basis = p.transform.basis * rot_y;`
	`1128`	`+ p.transform.basis = rot_y;`
`1129`	`1129`	`}`
`1130`	`1130`	`}`
`1131`	`1131`