Merge pull request #106151 from SaNeOr/fix-106123

Repiteo · Repiteo · commit 182be69a1eb6 · 2025-05-08T07:19:32.000-05:00
Fix editor crash when middle mouse button is clicked on empty space in scene tabs
diff --git a/scene/gui/tab_bar.cpp b/scene/gui/tab_bar.cpp
@@ -208,7 +208,9 @@ void TabBar::gui_input(const Ref<InputEvent> &p_event) {
 		}
 
 		if (close_with_middle_mouse && mb->is_pressed() && mb->get_button_index() == MouseButton::MIDDLE) {
-			emit_signal(SNAME("tab_close_pressed"), hover);
+			if (hover != -1) {
+				emit_signal(SNAME("tab_close_pressed"), hover);
+			}
 		}
 
 		if (mb->is_pressed() && (mb->get_button_index() == MouseButton::LEFT || (select_with_rmb && mb->get_button_index() == MouseButton::RIGHT))) {

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,9 @@ void TabBar::gui_input(const Ref<InputEvent> &p_event) {`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`if (close_with_middle_mouse && mb->is_pressed() && mb->get_button_index() == MouseButton::MIDDLE) {`
`211`		`- emit_signal(SNAME("tab_close_pressed"), hover);`
	`211`	`+ if (hover != -1) {`
	`212`	`+ emit_signal(SNAME("tab_close_pressed"), hover);`
	`213`	`+ }`
`212`	`214`	`}`
`213`	`215`
`214`	`216`	`if (mb->is_pressed() && (mb->get_button_index() == MouseButton::LEFT \|\| (select_with_rmb && mb->get_button_index() == MouseButton::RIGHT))) {`