Skip to content

Commit 1e12993

Browse files
dsnopekaaronfranke
dsnopek
and
aaronfranke
committed
Make Vector<T>::duplicate() const
Co-authored-by: Aaron Franke <[email protected]>
1 parent 7bccd51 commit 1e12993

File tree

13 files changed

+64
-11
lines changed

13 files changed

+64
-11
lines changed

‎core/templates/vector.h‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,16 @@ class Vector {
184184
return span().bisect(p_value, p_before, Comparator{ args... });
185185
}
186186

187-
Vector<T> duplicate() {
187+
Vector<T> duplicate() const {
188188
return *this;
189189
}
190190

191+
#ifndef DISABLE_DEPRECATED
192+
Vector<T> _duplicate_bind_compat_112290() {
193+
return *this;
194+
}
195+
#endif // DISABLE_DEPRECATED
196+
191197
void ordered_insert(const T &p_val) {
192198
Size i;
193199
for (i = 0; i < _cowdata.size(); i++) {

‎core/variant/variant_call.cpp‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2753,6 +2753,9 @@ static void _register_variant_builtin_methods_array() {
27532753
bind_method(PackedByteArray, sort, sarray(), varray());
27542754
bind_method(PackedByteArray, bsearch, sarray("value", "before"), varray(true));
27552755
bind_method(PackedByteArray, duplicate, sarray(), varray());
2756+
#ifndef DISABLE_DEPRECATED
2757+
bind_compat_method(PackedByteArray, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2758+
#endif
27562759
bind_method(PackedByteArray, find, sarray("value", "from"), varray(0));
27572760
bind_method(PackedByteArray, rfind, sarray("value", "from"), varray(-1));
27582761
bind_method(PackedByteArray, count, sarray("value"), varray());
@@ -2829,6 +2832,9 @@ static void _register_variant_builtin_methods_array() {
28292832
bind_method(PackedInt32Array, sort, sarray(), varray());
28302833
bind_method(PackedInt32Array, bsearch, sarray("value", "before"), varray(true));
28312834
bind_method(PackedInt32Array, duplicate, sarray(), varray());
2835+
#ifndef DISABLE_DEPRECATED
2836+
bind_compat_method(PackedInt32Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2837+
#endif
28322838
bind_method(PackedInt32Array, find, sarray("value", "from"), varray(0));
28332839
bind_method(PackedInt32Array, rfind, sarray("value", "from"), varray(-1));
28342840
bind_method(PackedInt32Array, count, sarray("value"), varray());
@@ -2853,6 +2859,9 @@ static void _register_variant_builtin_methods_array() {
28532859
bind_method(PackedInt64Array, sort, sarray(), varray());
28542860
bind_method(PackedInt64Array, bsearch, sarray("value", "before"), varray(true));
28552861
bind_method(PackedInt64Array, duplicate, sarray(), varray());
2862+
#ifndef DISABLE_DEPRECATED
2863+
bind_compat_method(PackedInt64Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2864+
#endif
28562865
bind_method(PackedInt64Array, find, sarray("value", "from"), varray(0));
28572866
bind_method(PackedInt64Array, rfind, sarray("value", "from"), varray(-1));
28582867
bind_method(PackedInt64Array, count, sarray("value"), varray());
@@ -2877,6 +2886,9 @@ static void _register_variant_builtin_methods_array() {
28772886
bind_method(PackedFloat32Array, sort, sarray(), varray());
28782887
bind_method(PackedFloat32Array, bsearch, sarray("value", "before"), varray(true));
28792888
bind_method(PackedFloat32Array, duplicate, sarray(), varray());
2889+
#ifndef DISABLE_DEPRECATED
2890+
bind_compat_method(PackedFloat32Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2891+
#endif
28802892
bind_method(PackedFloat32Array, find, sarray("value", "from"), varray(0));
28812893
bind_method(PackedFloat32Array, rfind, sarray("value", "from"), varray(-1));
28822894
bind_method(PackedFloat32Array, count, sarray("value"), varray());
@@ -2901,6 +2913,9 @@ static void _register_variant_builtin_methods_array() {
29012913
bind_method(PackedFloat64Array, sort, sarray(), varray());
29022914
bind_method(PackedFloat64Array, bsearch, sarray("value", "before"), varray(true));
29032915
bind_method(PackedFloat64Array, duplicate, sarray(), varray());
2916+
#ifndef DISABLE_DEPRECATED
2917+
bind_compat_method(PackedFloat64Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2918+
#endif
29042919
bind_method(PackedFloat64Array, find, sarray("value", "from"), varray(0));
29052920
bind_method(PackedFloat64Array, rfind, sarray("value", "from"), varray(-1));
29062921
bind_method(PackedFloat64Array, count, sarray("value"), varray());
@@ -2925,6 +2940,9 @@ static void _register_variant_builtin_methods_array() {
29252940
bind_method(PackedStringArray, sort, sarray(), varray());
29262941
bind_method(PackedStringArray, bsearch, sarray("value", "before"), varray(true));
29272942
bind_method(PackedStringArray, duplicate, sarray(), varray());
2943+
#ifndef DISABLE_DEPRECATED
2944+
bind_compat_method(PackedStringArray, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2945+
#endif
29282946
bind_method(PackedStringArray, find, sarray("value", "from"), varray(0));
29292947
bind_method(PackedStringArray, rfind, sarray("value", "from"), varray(-1));
29302948
bind_method(PackedStringArray, count, sarray("value"), varray());
@@ -2949,6 +2967,9 @@ static void _register_variant_builtin_methods_array() {
29492967
bind_method(PackedVector2Array, sort, sarray(), varray());
29502968
bind_method(PackedVector2Array, bsearch, sarray("value", "before"), varray(true));
29512969
bind_method(PackedVector2Array, duplicate, sarray(), varray());
2970+
#ifndef DISABLE_DEPRECATED
2971+
bind_compat_method(PackedVector2Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2972+
#endif
29522973
bind_method(PackedVector2Array, find, sarray("value", "from"), varray(0));
29532974
bind_method(PackedVector2Array, rfind, sarray("value", "from"), varray(-1));
29542975
bind_method(PackedVector2Array, count, sarray("value"), varray());
@@ -2973,6 +2994,9 @@ static void _register_variant_builtin_methods_array() {
29732994
bind_method(PackedVector3Array, sort, sarray(), varray());
29742995
bind_method(PackedVector3Array, bsearch, sarray("value", "before"), varray(true));
29752996
bind_method(PackedVector3Array, duplicate, sarray(), varray());
2997+
#ifndef DISABLE_DEPRECATED
2998+
bind_compat_method(PackedVector3Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
2999+
#endif
29763000
bind_method(PackedVector3Array, find, sarray("value", "from"), varray(0));
29773001
bind_method(PackedVector3Array, rfind, sarray("value", "from"), varray(-1));
29783002
bind_method(PackedVector3Array, count, sarray("value"), varray());
@@ -2997,6 +3021,9 @@ static void _register_variant_builtin_methods_array() {
29973021
bind_method(PackedColorArray, sort, sarray(), varray());
29983022
bind_method(PackedColorArray, bsearch, sarray("value", "before"), varray(true));
29993023
bind_method(PackedColorArray, duplicate, sarray(), varray());
3024+
#ifndef DISABLE_DEPRECATED
3025+
bind_compat_method(PackedColorArray, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
3026+
#endif
30003027
bind_method(PackedColorArray, find, sarray("value", "from"), varray(0));
30013028
bind_method(PackedColorArray, rfind, sarray("value", "from"), varray(-1));
30023029
bind_method(PackedColorArray, count, sarray("value"), varray());
@@ -3021,6 +3048,9 @@ static void _register_variant_builtin_methods_array() {
30213048
bind_method(PackedVector4Array, sort, sarray(), varray());
30223049
bind_method(PackedVector4Array, bsearch, sarray("value", "before"), varray(true));
30233050
bind_method(PackedVector4Array, duplicate, sarray(), varray());
3051+
#ifndef DISABLE_DEPRECATED
3052+
bind_compat_method(PackedVector4Array, duplicate, _duplicate_bind_compat_112290, sarray(), varray());
3053+
#endif
30243054
bind_method(PackedVector4Array, find, sarray("value", "from"), varray(0));
30253055
bind_method(PackedVector4Array, rfind, sarray("value", "from"), varray(-1));
30263056
bind_method(PackedVector4Array, count, sarray("value"), varray());

‎doc/classes/PackedByteArray.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@
213213
[b]Note:[/b] Decompression is not guaranteed to work with data not compressed by Godot, for example if data compressed with the deflate compression mode lacks a checksum or header.
214214
</description>
215215
</method>
216-
<method name="duplicate">
216+
<method name="duplicate" qualifiers="const">
217217
<return type="PackedByteArray" />
218218
<description>
219219
Creates a copy of the array, and returns it.

‎doc/classes/PackedColorArray.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
Returns the number of times an element is in the array.
7474
</description>
7575
</method>
76-
<method name="duplicate">
76+
<method name="duplicate" qualifiers="const">
7777
<return type="PackedColorArray" />
7878
<description>
7979
Creates a copy of the array, and returns it.

‎doc/classes/PackedFloat32Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
[b]Note:[/b] [constant @GDScript.NAN] doesn't behave the same as other numbers. Therefore, the results from this method may not be accurate if NaNs are included.
7272
</description>
7373
</method>
74-
<method name="duplicate">
74+
<method name="duplicate" qualifiers="const">
7575
<return type="PackedFloat32Array" />
7676
<description>
7777
Creates a copy of the array, and returns it.

‎doc/classes/PackedFloat64Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
[b]Note:[/b] [constant @GDScript.NAN] doesn't behave the same as other numbers. Therefore, the results from this method may not be accurate if NaNs are included.
7373
</description>
7474
</method>
75-
<method name="duplicate">
75+
<method name="duplicate" qualifiers="const">
7676
<return type="PackedFloat64Array" />
7777
<description>
7878
Creates a copy of the array, and returns it.

‎doc/classes/PackedInt32Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
Returns the number of times an element is in the array.
7070
</description>
7171
</method>
72-
<method name="duplicate">
72+
<method name="duplicate" qualifiers="const">
7373
<return type="PackedInt32Array" />
7474
<description>
7575
Creates a copy of the array, and returns it.

‎doc/classes/PackedInt64Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
Returns the number of times an element is in the array.
7171
</description>
7272
</method>
73-
<method name="duplicate">
73+
<method name="duplicate" qualifiers="const">
7474
<return type="PackedInt64Array" />
7575
<description>
7676
Creates a copy of the array, and returns it.

‎doc/classes/PackedStringArray.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
Returns the number of times an element is in the array.
7777
</description>
7878
</method>
79-
<method name="duplicate">
79+
<method name="duplicate" qualifiers="const">
8080
<return type="PackedStringArray" />
8181
<description>
8282
Creates a copy of the array, and returns it.

‎doc/classes/PackedVector2Array.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
[b]Note:[/b] Vectors with [constant @GDScript.NAN] elements don't behave the same as other vectors. Therefore, the results from this method may not be accurate if NaNs are included.
7777
</description>
7878
</method>
79-
<method name="duplicate">
79+
<method name="duplicate" qualifiers="const">
8080
<return type="PackedVector2Array" />
8181
<description>
8282
Creates a copy of the array, and returns it.

0 commit comments

Comments
 (0)