Merge pull request #97130 from Rindbee/check-space-in-remove_soft_body_from_query

akien-mga · akien-mga · commit 3abff94a24f9 · 2024-09-18T11:15:47.000+02:00
Add forgotten `get_space()` check in `GodotArea3D::remove_soft_body_from_query()`
diff --git a/servers/physics_3d/godot_area_3d.h b/servers/physics_3d/godot_area_3d.h
@@ -188,7 +188,7 @@ void GodotArea3D::add_soft_body_to_query(GodotSoftBody3D *p_soft_body, uint32_t
 void GodotArea3D::remove_soft_body_from_query(GodotSoftBody3D *p_soft_body, uint32_t p_soft_body_shape, uint32_t p_area_shape) {
 	BodyKey bk(p_soft_body, p_soft_body_shape, p_area_shape);
 	monitored_soft_bodies[bk].dec();
-	if (!monitor_query_list.in_list()) {
+	if (get_space() && !monitor_query_list.in_list()) {
 		_queue_monitor_update();
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ void GodotArea3D::add_soft_body_to_query(GodotSoftBody3D *p_soft_body, uint32_t`
`188`	`188`	`void GodotArea3D::remove_soft_body_from_query(GodotSoftBody3D *p_soft_body, uint32_t p_soft_body_shape, uint32_t p_area_shape) {`
`189`	`189`	`BodyKey bk(p_soft_body, p_soft_body_shape, p_area_shape);`
`190`	`190`	`monitored_soft_bodies[bk].dec();`
`191`		`- if (!monitor_query_list.in_list()) {`
	`191`	`+ if (get_space() && !monitor_query_list.in_list()) {`
`192`	`192`	`_queue_monitor_update();`
`193`	`193`	`}`
`194`	`194`	`}`