FileAccessMemory: prevent seeking past end of file

nikitalita · nikitalita · commit 3fa73d4f5fc2 · 2025-11-02T12:40:51.000-08:00
diff --git a/core/io/file_access_memory.cpp b/core/io/file_access_memory.cpp
@@ -98,12 +98,14 @@ bool FileAccessMemory::is_open() const {
 
 void FileAccessMemory::seek(uint64_t p_position) {
 	ERR_FAIL_NULL(data);
+	ERR_FAIL_COND(p_position > length);
 	pos = p_position;
 }
 
 void FileAccessMemory::seek_end(int64_t p_position) {
 	ERR_FAIL_NULL(data);
-	pos = length + p_position;
+	ERR_FAIL_COND((int64_t)length + p_position < 0);
+	seek(length + p_position);
 }
 
 uint64_t FileAccessMemory::get_position() const {

Original file line number	Diff line number	Diff line change
`@@ -98,12 +98,14 @@ bool FileAccessMemory::is_open() const {`
`98`	`98`
`99`	`99`	`void FileAccessMemory::seek(uint64_t p_position) {`
`100`	`100`	`ERR_FAIL_NULL(data);`
	`101`	`+ ERR_FAIL_COND(p_position > length);`
`101`	`102`	`pos = p_position;`
`102`	`103`	`}`
`103`	`104`
`104`	`105`	`void FileAccessMemory::seek_end(int64_t p_position) {`
`105`	`106`	`ERR_FAIL_NULL(data);`
`106`		`- pos = length + p_position;`
	`107`	`+ ERR_FAIL_COND((int64_t)length + p_position < 0);`
	`108`	`+ seek(length + p_position);`
`107`	`109`	`}`
`108`	`110`
`109`	`111`	`uint64_t FileAccessMemory::get_position() const {`