Merge pull request #101343 from DarioSamo/shader-reflection-fix

akien-mga · akien-mga · commit 7285e89407a9 · 2025-01-09T17:07:20.000+01:00
Fix duplicated spec constant on SPIR-V reflection.
diff --git a/servers/rendering/rendering_device_driver.cpp b/servers/rendering/rendering_device_driver.cpp
@@ -259,7 +259,7 @@ Error RenderingDeviceDriver::_reflect_spirv(VectorView<ShaderStageSPIRVData> p_s
 							}
 						}
 
-						if (existing > 0) {
+						if (existing >= 0) {
 							r_reflection.specialization_constants.write[existing].stages.set_flag(stage_flag);
 						} else {
 							r_reflection.specialization_constants.push_back(sconst);

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ Error RenderingDeviceDriver::_reflect_spirv(VectorView<ShaderStageSPIRVData> p_s`
`259`	`259`	`}`
`260`	`260`	`}`
`261`	`261`
`262`		`- if (existing > 0) {`
	`262`	`+ if (existing >= 0) {`
`263`	`263`	`r_reflection.specialization_constants.write[existing].stages.set_flag(stage_flag);`
`264`	`264`	`} else {`
`265`	`265`	`r_reflection.specialization_constants.push_back(sconst);`