Skip to content

Commit 8bff45a

Browse files
committed
Merge pull request #113573 from MattiaZir/fix-color-picker-crash
Fix memory management for ColorPalette in save file dialog
2 parents 27b1859 + bf85f96 commit 8bff45a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

scene/gui/color_picker.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -974,7 +974,8 @@ void ColorPicker::_palette_file_selected(const String &p_path) {
974974
#endif
975975
} break;
976976
case FileDialog::FileMode::FILE_MODE_SAVE_FILE: {
977-
ColorPalette *palette = memnew(ColorPalette);
977+
Ref<ColorPalette> palette;
978+
palette.instantiate();
978979
palette->set_colors(get_presets());
979980
Error error = ResourceSaver::save(palette, p_path);
980981
ERR_FAIL_COND_MSG(error != Error::OK, vformat("Cannot open color palette file for writing at: %s", p_path));

0 commit comments

Comments
 (0)