Merge pull request #110049 from bruvzg/no_flags_on_hide

Repiteo · Repiteo · commit ac4c97e278a1 · 2025-08-29T12:00:40.000-05:00
Do not set flags when `PopupMenu::set_visible` is called to hide popup.
diff --git a/scene/gui/popup_menu.cpp b/scene/gui/popup_menu.cpp
@@ -3247,7 +3247,7 @@ void PopupMenu::set_visible(bool p_visible) {
 			_native_popup(Rect2i(get_position(), get_size()));
 		}
 	} else {
-		if (is_inside_tree()) {
+		if (p_visible && is_inside_tree()) {
 			set_flag(FLAG_POPUP, true);
 			set_flag(FLAG_NO_FOCUS, !is_embedded());
 		}

Original file line number	Diff line number	Diff line change
`@@ -3247,7 +3247,7 @@ void PopupMenu::set_visible(bool p_visible) {`
`3247`	`3247`	`_native_popup(Rect2i(get_position(), get_size()));`
`3248`	`3248`	`}`
`3249`	`3249`	`} else {`
`3250`		`- if (is_inside_tree()) {`
	`3250`	`+ if (p_visible && is_inside_tree()) {`
`3251`	`3251`	`set_flag(FLAG_POPUP, true);`
`3252`	`3252`	`set_flag(FLAG_NO_FOCUS, !is_embedded());`
`3253`	`3253`	`}`