Skip to content

Commit b0d5126

Browse files
committed
Merge pull request #97570 from dustdfg/ios_macos/print_warning_instead_of_comments
Replace comments with printed warning for Metal on x86_64
2 parents def5a04 + 1abcfdd commit b0d5126

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

platform/ios/detect.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import sys
33
from typing import TYPE_CHECKING
44

5-
from methods import detect_darwin_sdk_path, print_error
5+
from methods import detect_darwin_sdk_path, print_error, print_warning
66

77
if TYPE_CHECKING:
88
from SCons.Script.SConscript import SConsEnvironment
@@ -156,7 +156,7 @@ def configure(env: "SConsEnvironment"):
156156
env.Append(CPPDEFINES=["IOS_ENABLED", "UNIX_ENABLED", "COREAUDIO_ENABLED"])
157157

158158
if env["metal"] and env["arch"] != "arm64":
159-
# Only supported on arm64, so skip it for x86_64 builds.
159+
print_warning("Target architecture '{}' does not support the Metal rendering driver".format(env["arch"]))
160160
env["metal"] = False
161161

162162
if env["metal"]:

platform/macos/detect.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import sys
33
from typing import TYPE_CHECKING
44

5-
from methods import detect_darwin_sdk_path, get_compiler_version, is_vanilla_clang, print_error
5+
from methods import detect_darwin_sdk_path, get_compiler_version, is_vanilla_clang, print_error, print_warning
66
from platform_methods import detect_arch, detect_mvk
77

88
if TYPE_CHECKING:
@@ -249,7 +249,7 @@ def configure(env: "SConsEnvironment"):
249249
env.Append(LINKFLAGS=["-rpath", "@executable_path/../Frameworks", "-rpath", "@executable_path"])
250250

251251
if env["metal"] and env["arch"] != "arm64":
252-
# Only supported on arm64, so skip it for x86_64 builds.
252+
print_warning("Target architecture '{}' does not support the Metal rendering driver".format(env["arch"]))
253253
env["metal"] = False
254254

255255
extra_frameworks = set()

0 commit comments

Comments
 (0)