Skip to content

Commit b4a99e7

Browse files
committed
Merge pull request #109843 from Muller-Castro/fix-fileaccess-create-temp
Fix `FileAccess::create_temp()` default args error
2 parents d8b057d + be68ff8 commit b4a99e7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

core/io/file_access.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ Ref<FileAccess> FileAccess::create_for_path(const String &p_path) {
8181
Ref<FileAccess> FileAccess::create_temp(int p_mode_flags, const String &p_prefix, const String &p_extension, bool p_keep, Error *r_error) {
8282
const String ERROR_COMMON_PREFIX = "Error while creating temporary file";
8383

84-
if (!p_prefix.is_valid_filename()) {
84+
if (!p_prefix.is_empty() && !p_prefix.is_valid_filename()) {
8585
*r_error = ERR_FILE_BAD_PATH;
8686
ERR_FAIL_V_MSG(Ref<FileAccess>(), vformat(R"(%s: "%s" is not a valid prefix.)", ERROR_COMMON_PREFIX, p_prefix));
8787
}
8888

89-
if (!p_extension.is_valid_filename()) {
89+
if (!p_extension.is_empty() && !p_extension.is_valid_filename()) {
9090
*r_error = ERR_FILE_BAD_PATH;
9191
ERR_FAIL_V_MSG(Ref<FileAccess>(), vformat(R"(%s: "%s" is not a valid extension.)", ERROR_COMMON_PREFIX, p_extension));
9292
}

0 commit comments

Comments
 (0)