System info: Remove empty parentheses when video adapter driver name is unknown

akien-mga · akien-mga · commit b6ad4b193f02 · 2024-06-11T16:18:20.000+02:00
Seems to be the case at least for me on Fedora, and in various issues I see from
other Linux users.
diff --git a/editor/editor_node.cpp b/editor/editor_node.cpp
@@ -4928,7 +4928,7 @@ String EditorNode::_get_system_info() const {
 		const String &vad_version = video_adapter_driver_info[1]; // Version could be potentially empty on Linux/BSD.
 		if (!vad_version.is_empty()) {
 			graphics += vformat(" (%s; %s)", vad_name, vad_version);
-		} else {
+		} else if (!vad_name.is_empty()) {
 			graphics += vformat(" (%s)", vad_name);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -4928,7 +4928,7 @@ String EditorNode::_get_system_info() const {`
`4928`	`4928`	`const String &vad_version = video_adapter_driver_info[1]; // Version could be potentially empty on Linux/BSD.`
`4929`	`4929`	`if (!vad_version.is_empty()) {`
`4930`	`4930`	`graphics += vformat(" (%s; %s)", vad_name, vad_version);`
`4931`		`- } else {`
	`4931`	`+ } else if (!vad_name.is_empty()) {`
`4932`	`4932`	`graphics += vformat(" (%s)", vad_name);`
`4933`	`4933`	`}`
`4934`	`4934`	`}`